Skip to content

Commit 714d88c

Browse files
authored
Merge pull request #1694 from dandi/enh-staging
Bring back dandi-staging to provide more graceful transition for 3rd party libraries
2 parents 4c8eb54 + bb981a7 commit 714d88c

File tree

4 files changed

+18
-0
lines changed

4 files changed

+18
-0
lines changed

dandi/cli/tests/test_instances.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ def test_cmd_instances(monkeypatch):
1919
"dandi-sandbox:\n"
2020
" api: https://api.sandbox.dandiarchive.org/api\n"
2121
" gui: https://sandbox.dandiarchive.org\n"
22+
"dandi-staging:\n"
23+
" api: https://api.sandbox.dandiarchive.org/api\n"
24+
" gui: https://sandbox.dandiarchive.org\n"
2225
"ember:\n"
2326
" api: https://api-dandi.emberarchive.org/api\n"
2427
" gui: https://dandi.emberarchive.org\n"

dandi/consts.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,13 @@ def urls(self) -> Iterator[str]:
122122
"https://dandiarchive.org",
123123
"https://api.dandiarchive.org/api",
124124
),
125+
# Deprecated. Remove early 2026.
126+
# Should come before dandi-sandbox so _rev map does map to sandbox
127+
"dandi-staging": DandiInstance(
128+
"dandi-staging",
129+
"https://sandbox.dandiarchive.org",
130+
"https://api.sandbox.dandiarchive.org/api",
131+
),
125132
"dandi-sandbox": DandiInstance(
126133
"dandi-sandbox",
127134
"https://sandbox.dandiarchive.org",

dandi/utils.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -576,6 +576,11 @@ def get_instance(dandi_instance_id: str | DandiInstance) -> DandiInstance:
576576
else:
577577
dandi_id = dandi_instance_id
578578
instance = known_instances[dandi_id]
579+
if dandi_id == "dandi-staging":
580+
lgr.warning(
581+
"'dandi-staging' DANDI instance identifier is deprecated. "
582+
"The instance was renamed into 'dandi-sandbox', please use that identifier instead."
583+
)
579584
if redirector_url is None:
580585
assert instance is not None
581586
return _get_instance(instance.api.rstrip("/"), True, instance, dandi_id)

docs/source/cmdline/instances.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@ Example output:
2222
dandi-sandbox:
2323
api: https://api.sandbox.dandiarchive.org/api
2424
gui: https://sandbox.dandiarchive.org
25+
dandi-staging:
26+
api: https://api.sandbox.dandiarchive.org/api
27+
gui: https://sandbox.dandiarchive.org
2528
linc-staging:
2629
api: https://staging-api.lincbrain.org/api
2730
gui: https://staging.lincbrain.org

0 commit comments

Comments
 (0)