test: update test to ensure hint for dandiset.yaml

Author: candleindark

dandi/tests/test_validate.py

@@ -114,30 +114,18 @@ def mock_bids_validate(*args: Any, **kwargs: Any) -> list[ValidationResult]:
     assert err.dataset_path is not None
     assert err.path.relative_to(err.dataset_path).as_posix() == dandiset_metadata_file
 
-    # The error message should be the original BIDS error, not modified
-    assert err.message is not None
-    # We just check that it's about dandiset.yaml, not checking exact message
-    # since it comes from BIDS validator
-
-    # Check that there is also a HINT about .bidsignore
-    validation_hints = [
-        r
-        for r in validation_results
-        if r.severity is not None and r.severity == Severity.HINT
-    ]
-
-    # Assert that there is at least one hint
-    assert len(validation_hints) >= 1
-
-    # Find the hint about .bidsignore for dandiset.yaml
-    bidsignore_hint = next(
-        (h for h in validation_hints if h.id == "DANDI.BIDSIGNORE_DANDISET_YAML"),
-        None,
-    )
-    assert bidsignore_hint is not None
-    assert bidsignore_hint.message is not None
-    assert ".bidsignore" in bidsignore_hint.message
-    assert dandiset_metadata_file in bidsignore_hint.message
+    # === Assert that there is the dandiset.yaml hint ===
+    i = None
+    for i, r in enumerate(validation_results):
+        if r is err:
+            break
+
+    assert i is not None
+    # There must be at least one more result after the error
+    assert len(validation_results) > i + 1
+    # The next result must be the hint re: dandiset.yaml
+    assert validation_results[i + 1].id == "DANDI.BIDSIGNORE_DANDISET_YAML"
+    assert validation_results[i + 1].severity == Severity.HINT
 
 
 def test_validate_bids_onefile(bids_error_examples: Path, tmp_path: Path) -> None: