Skip to content

Commit 35f7792

Browse files
committed
Make identifier singular (remove possibility for a list of identifiers) for Locus and Allele
So far I see no values with such data types used at all in dandi archive so we should not break anything An alternative would be to just make it a List[Identifier] always and not bother allowing for the dance of singular-vs-plural.
1 parent feb208f commit 35f7792

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

dandischema/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1340,7 +1340,7 @@ class PublishActivity(Activity):
13401340

13411341

13421342
class Locus(DandiBaseModel):
1343-
identifier: Union[Identifier, List[Identifier]] = Field(
1343+
identifier: Identifier = Field(
13441344
description="Identifier for genotyping locus.",
13451345
json_schema_extra={"nskey": "schema"},
13461346
)
@@ -1352,7 +1352,7 @@ class Locus(DandiBaseModel):
13521352

13531353

13541354
class Allele(DandiBaseModel):
1355-
identifier: Union[Identifier, List[Identifier]] = Field(
1355+
identifier: Identifier = Field(
13561356
description="Identifier for genotyping allele.",
13571357
json_schema_extra={"nskey": "schema"},
13581358
)

0 commit comments

Comments
 (0)