Skip to content

Must call compiler.close() to write webpack filesystem cache #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snickell wants to merge 2 commits into from
Closed

Must call compiler.close() to write webpack filesystem cache #250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b00669
Call compiler.close() so webpack writes cache to disk
snickell Nov 6, 2025
39e172b
Version with minimal diff / local changes only (tested, works)
snickell Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion tasks/webpack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
return;
}

const compilerClosePromises = [];

targets.forEach((target) => {
if (target === "options") {
runningTargetCount--;
Expand Down Expand Up @@ -97,7 +99,16 @@

keepalive = keepalive || opts.keepalive;

if (--runningTargetCount === 0 && !keepalive) done();
if (!keepalive) {
compilerClosePromises.push(new Promise((resolve, reject) =>

Check failure on line 103 in tasks/webpack.js

View workflow job for this annotation

GitHub Actions / Lint 

Insert `⏎················`
compiler.close((err) => err ? reject(err) : resolve())

Check warning on line 104 in tasks/webpack.js

View workflow job for this annotation

GitHub Actions / Lint 

'err' is already declared in the upper scope on line 66 column 28

Check failure on line 104 in tasks/webpack.js

View workflow job for this annotation

GitHub Actions / Lint 

Replace `compiler.close((err)·=>·err·?·reject(err)·:·resolve())` with `··compiler.close((err)·=>·(err·?·reject(err)·:·resolve())),`
));

Check failure on line 105 in tasks/webpack.js

View workflow job for this annotation

GitHub Actions / Lint 

Replace `··············)` with `················),⏎··············`
if (--runningTargetCount === 0) {
Promise.all(compilerClosePromises)
.then(() => done())
.catch((err) => done(err));

Check warning on line 109 in tasks/webpack.js

View workflow job for this annotation

GitHub Actions / Lint 

'err' is already declared in the upper scope on line 66 column 28
}
}
};

if (opts.watch) {
Expand Down
Loading