chore: Switch from tslint to eslint

tslint is end-of-life, and warns when you install it. Additionally, the version we were on didn't support 'import type' expressions, as well as optional-chaining & null coalescing when I tried to use those in #1204

This PR does update a bunch of tslint-disable comments, but otherwise tries to minimally change runtime source in danger-js. If we want to tighten the eslint rules, I'd be super supportive, but I didn't want to cause a ton of thrash, so mostly the rules that are enabled are the ones that don't trigger on tons of existing code.

Author: fbartho

.eslintignore

@@ -0,0 +1,2 @@
+source/danger.d.ts
+source/runner/_tests/fixtures/*.ts

.eslintrc.js

@@ -0,0 +1,66 @@
+module.exports = {
+  env: {
+    browser: true,
+    es6: true,
+    node: true,
+  },
+  extends: ["plugin:@typescript-eslint/recommended", "plugin:jest/recommended", "prettier"],
+  parser: "@typescript-eslint/parser",
+  parserOptions: {
+    project: "tsconfig.spec.json",
+    sourceType: "module",
+  },
+  plugins: ["eslint-plugin-jest", "eslint-plugin-jsdoc", "@typescript-eslint"],
+  rules: {
+    "@typescript-eslint/naming-convention": "error",
+    "@typescript-eslint/no-empty-function": "error",
+    "@typescript-eslint/no-unused-expressions": "error",
+
+    // Something is grumpy about these rules re: node imports - TODO
+    "@typescript-eslint/no-require-imports": "off",
+    "@typescript-eslint/no-var-requires": "off",
+
+    curly: "error",
+    "jsdoc/check-alignment": "error",
+    "jsdoc/check-indentation": "off",
+    "jsdoc/newline-after-description": "off",
+    "no-empty": "error",
+    // This is used intentionally in a bunch of ci_source/providers
+    "no-empty-function": "off",
+    "no-redeclare": "error",
+    "no-var": "error",
+    // There are a bunch of existing uses of 'let' where this rule would trigger
+    "prefer-const": "off",
+
+    // This project has a ton of interacting APIs, and sometimes it's helpful to be explicit, even if the type is trivial
+    "@typescript-eslint/no-inferrable-types": "off",
+
+    "no-unused-expressions": "off",
+    "@typescript-eslint/no-unused-expressions": "error",
+
+    "no-unused-vars": "off",
+    "@typescript-eslint/no-unused-vars": [
+      "warn",
+      {
+        // Allow function args to be unused
+        args: "none",
+        argsIgnorePattern: "^_",
+        varsIgnorePattern: "^_",
+        caughtErrorsIgnorePattern: "^_",
+      },
+    ],
+
+    "jest/no-disabled-tests": "warn",
+    "jest/no-focused-tests": "error",
+    "jest/no-identical-title": "error",
+    "jest/prefer-to-have-length": "off",
+    "jest/valid-expect": "error",
+    "@typescript-eslint/no-non-null-assertion": "off",
+    // Tons of violations in the codebase
+    "@typescript-eslint/naming-convention": "off",
+    // Used liberally in the codebase
+    "@typescript-eslint/no-explicit-any": "off",
+    // This has value in communicating with other Developers even if it has no functional effect.
+    "@typescript-eslint/no-empty-interface": "off",
+  },
+}

.vscode/extensions.json

@@ -2,6 +2,7 @@
   "recommendations": [
     "Orta.vscode-jest",
     "esbenp.prettier-vscode",
+    "dbaeumer.vscode-eslint",
     "christian-kohler.path-intellisense",
     "wayou.vscode-todo-highlight"
   ]

CHANGELOG.md

@@ -15,6 +15,7 @@
 
 <!-- Your comment below this -->
 
+- *Chore:* Switch from tslint to eslint (tslint is end-of-life) - [#1205](https://github.com/danger/danger-js/pull/1205) [@fbartho]
 
 <!-- Your comment above this -->
 

package.json

@@ -34,7 +34,7 @@
       "git add"
     ],
     "*.@(ts|tsx)": [
-      "tslint --fix",
+      "eslint --fix",
       "yarn prettier --write",
       "git add"
     ]
@@ -56,8 +56,8 @@
     "test:fixtures": "node ./scripts/run-fixtures.js",
     "test:update-fixtures": "yarn test:fixtures --update",
     "test:watch": "jest --watch",
-    "lint": "tslint \"source/**/*.ts\"",
-    "lint:fix": "tslint \"source/**/*.ts\" --fix",
+    "lint": "eslint \"source/*.ts\" \"source/**/*.ts\"",
+    "lint:fix": "yarn --silent lint --fix",
     "prepublishOnly": "yarn build && yarn jest && yarn declarations && yarn build:flow-types && yarn build:pretty-types",
     "build": "shx rm -rf ./distribution && tsc -p tsconfig.production.json && madge ./distribution --circular",
     "build:fast": "tsc -p tsconfig.production.json",
@@ -114,9 +114,15 @@
     "@types/prettier": "^1.16.1",
     "@types/readline-sync": "^1.4.3",
     "@types/voca": "^1.4.0",
+    "@typescript-eslint/eslint-plugin": "^5.10.1",
+    "@typescript-eslint/parser": "^5.10.1",
     "danger-plugin-jest": "^1.0.1",
     "danger-plugin-yarn": "^1.3.1",
     "date-fns": "^1.29.0",
+    "eslint": "^8.8.0",
+    "eslint-config-prettier": "^8.3.0",
+    "eslint-plugin-jest": "^26.0.0",
+    "eslint-plugin-jsdoc": "^37.7.0",
     "flow-bin": "^0.77.0",
     "husky": "^1.0.1",
     "jest": "^24.0.0",
@@ -130,8 +136,6 @@
     "shx": "^0.3.2",
     "ts-jest": "^24.0.2",
     "ts-node": "^8.0.2",
-    "tslint": "^5.11.0",
-    "tslint-config-prettier": "^1.15.0",
     "typedoc": "0.9.0",
     "typescript": "^4.5.5",
     "typescript-json-schema": "^0.32.0"

source/api/fetch.ts

@@ -63,12 +63,12 @@ export function api(
   url: string | node_fetch.Request,
   init: node_fetch.RequestInit,
   suppressErrorReporting?: boolean,
-  provessEnv: NodeJS.ProcessEnv = process.env
+  processEnv: NodeJS.ProcessEnv = process.env
 ): Promise<node_fetch.Response> {
   const isTests = typeof jest !== "undefined"
   if (isTests && !url.toString().includes("localhost")) {
     const message = `No API calls in tests please: ${url}`
-    debugger // tslint:disable-line
+    debugger
     throw new Error(message)
   }
 
@@ -79,8 +79,8 @@ export function api(
       output.push(`-X ${init.method}`)
     }
 
-    const showToken = provessEnv["DANGER_VERBOSE_SHOW_TOKEN"]
-    const token = provessEnv["DANGER_GITHUB_API_TOKEN"] || provessEnv["GITHUB_TOKEN"]
+    const showToken = processEnv["DANGER_VERBOSE_SHOW_TOKEN"]
+    const token = processEnv["DANGER_GITHUB_API_TOKEN"] || processEnv["GITHUB_TOKEN"]
 
     if (init.headers) {
       for (const prop in init.headers) {
@@ -109,7 +109,7 @@ export function api(
 
   let agent = init.agent
   const proxy =
-    provessEnv["HTTPS_PROXY"] || provessEnv["https_proxy"] || provessEnv["HTTP_PROXY"] || provessEnv["http_proxy"]
+    processEnv["HTTPS_PROXY"] || processEnv["https_proxy"] || processEnv["HTTP_PROXY"] || processEnv["http_proxy"]
 
   if (!agent && proxy) {
     let secure = url.toString().startsWith("https")

source/ci_source/get_ci_source.ts

@@ -30,7 +30,8 @@ export async function getCISourceForExternal(env: Env, modulePath: string): Prom
         console.error(`could not load CI provider at ${modulePath} due to ${error}`)
       }
       if (stat && stat.isFile()) {
-        const externalModule = require(path) //tslint:disable-line:no-require-imports
+        // eslint-disable-next-line
+        const externalModule = require(path) //  @typescript-eslint/no-var-requires @typescript-eslint/no-require-imports
         const moduleConstructor = externalModule.default || externalModule
         resolve(new moduleConstructor(env))
       }

source/ci_source/providers/_tests/_bamboo.test.ts

@@ -54,6 +54,7 @@ describe(".isPR", () => {
 
     it("needs to have a PR number", () => {
       let env = Object.assign({}, correctEnv)
+      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-ignore
       delete env["bamboo_repository_pr_key"]
       const pipelines = new Bamboo(env)

source/ci_source/providers/_tests/_buddyWorks.test.ts

@@ -52,6 +52,7 @@ describe(".isPR", () => {
 
   it("needs to have a PR number", () => {
     const env = Object.assign({}, correctEnv)
+    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
     // @ts-ignore
     delete env.BUDDY_EXECUTION_PULL_REQUEST_NO
     const buddyWorks = new BuddyWorks(env)

source/ci_source/providers/_tests/_codebuild.test.ts

@@ -9,7 +9,7 @@ const correctEnv = {
   DANGER_GITHUB_API_TOKEN: "xxx",
 }
 
-const setupCodeBuildSource = async (env: Object) => {
+const setupCodeBuildSource = async (env: Record<string, unknown>) => {
   const source = new CodeBuild(env)
   await source.setup()