Merge pull request #1395 from glensc/1381-fix

orta · web-flow · commit 8bba64f73be7 · 2023-07-31T11:56:22.000+01:00
Add dangerID to gitlab createComment api
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@
 ## Main
 
 <!-- Your comment below this -->
+- Add dangerID to gitlab createComment api #1395 [@glensc]
 <!-- Your comment above this -->
 
 ## 11.2.7
diff --git a/source/platforms/GitLab.ts b/source/platforms/GitLab.ts
@@ -114,7 +114,7 @@ class GitLab implements Platform {
         newOrUpdatedNote = await this.api.updateMergeRequestNote(existingNote.id, newComment)
       } else {
         // create a new comment
-        newOrUpdatedNote = await this.createComment(newComment)
+        newOrUpdatedNote = await this.createComment(dangerID, newComment)
       }
 
       // create URL from note
@@ -145,7 +145,7 @@ class GitLab implements Platform {
     }
   }
 
-  createComment = async (comment: string): Promise<GitLabNote> => {
+  createComment = async (_dangerID: string, comment: string): Promise<GitLabNote> => {
     d("createComment", { comment })
     if (useThreads()) {
       return (await this.api.createMergeRequestDiscussion(comment)).notes[0]

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ class GitLab implements Platform {`
`114`	`114`	`newOrUpdatedNote = await this.api.updateMergeRequestNote(existingNote.id, newComment)`
`115`	`115`	`} else {`
`116`	`116`	`// create a new comment`
`117`		`- newOrUpdatedNote = await this.createComment(newComment)`
	`117`	`+ newOrUpdatedNote = await this.createComment(dangerID, newComment)`
`118`	`118`	`}`
`119`	`119`
`120`	`120`	`// create URL from note`
`@@ -145,7 +145,7 @@ class GitLab implements Platform {`
`145`	`145`	`}`
`146`	`146`	`}`
`147`	`147`
`148`		`- createComment = async (comment: string): Promise<GitLabNote> => {`
	`148`	`+ createComment = async (_dangerID: string, comment: string): Promise<GitLabNote> => {`
`149`	`149`	`d("createComment", { comment })`
`150`	`150`	`if (useThreads()) {`
`151`	`151`	`return (await this.api.createMergeRequestDiscussion(comment)).notes[0]`