Skip to content

Commit 440ef2f

Browse files
author
Oscar Costoya Vidal
committed
Merge remote-tracking branch 'original/master'
2 parents 09f1626 + bddac4e commit 440ef2f

File tree

10 files changed

+73
-571
lines changed

10 files changed

+73
-571
lines changed

.github/workflows/ci.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
strategy:
1919
fail-fast: false
2020
matrix:
21-
xcode: ["13.2.1", "13.4.1", "14.0.1"]
21+
xcode: ["13.2.1", "13.4.1", "14.1"]
2222
steps:
2323
- uses: actions/checkout@v2
2424

@@ -57,7 +57,7 @@ jobs:
5757
strategy:
5858
fail-fast: false
5959
matrix:
60-
xcode: ["13.2.1", "13.4.1", "14.0.1"]
60+
xcode: ["13.2.1", "13.4.1", "14.1"]
6161
steps:
6262
- uses: actions/checkout@v2
6363

@@ -94,11 +94,11 @@ jobs:
9494

9595
test-on-linux:
9696
name: Test on Linux
97-
runs-on: ubuntu-latest
97+
runs-on: ubuntu-20.04
9898
strategy:
9999
fail-fast: false
100100
matrix:
101-
swift: ["5.4.3", "5.5.3", "5.6.3", "5.7"]
101+
swift: ["5.5.3", "5.6.3", "5.7"]
102102
steps:
103103
- uses: actions/checkout@v2
104104
- uses: actions/setup-node@v2
@@ -124,7 +124,7 @@ jobs:
124124

125125
- uses: YOCKOW/Action-setup-swift@v1
126126

127-
- run: swift test
127+
- run: swift test --enable-test-discovery
128128

129129
- run: swift run danger-swift ci --verbose --failOnErrors
130130
if: ${{ github.event_name == 'pull_request' }}
@@ -137,7 +137,7 @@ jobs:
137137
strategy:
138138
fail-fast: false
139139
matrix:
140-
xcode: ["13.2.1", "13.4.1", "14.0.1"]
140+
xcode: ["13.2.1", "13.4.1", "14.1"]
141141
steps:
142142
- uses: actions/checkout@v2
143143

@@ -172,11 +172,11 @@ jobs:
172172

173173
test-without-spm-on-linux:
174174
name: Test without SPM on Linux
175-
runs-on: ubuntu-latest
175+
runs-on: ubuntu-20.04
176176
strategy:
177177
fail-fast: false
178178
matrix:
179-
swift: ["5.4.3", "5.5.3", "5.6.3", "5.7"]
179+
swift: ["5.5.3", "5.6.3", "5.7"]
180180
steps:
181181
- uses: actions/checkout@v2
182182
- uses: actions/setup-node@v2

.swift-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
5.4
1+
5.5

Package.resolved

Lines changed: 35 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Package.swift

Lines changed: 24 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// swift-tools-version:5.4
1+
// swift-tools-version:5.5
22

33
import PackageDescription
44

@@ -13,17 +13,31 @@ let devProducts: [Product] = isDevelop
1313
] : []
1414
let devDependencies: [Package.Dependency] = isDevelop
1515
? [
16-
.package(url: "https://github.com/shibapm/Komondor", from: "1.1.3"),
17-
.package(url: "https://github.com/nicklockwood/SwiftFormat", from: "0.49.4"),
18-
.package(url: "https://github.com/Realm/SwiftLint", from: "0.46.2"),
19-
.package(name: "SnapshotTesting", url: "https://github.com/pointfreeco/swift-snapshot-testing.git", from: "1.7.1"),
16+
.package(url: "https://github.com/shibapm/Komondor", from: "1.1.4"),
17+
.package(url: "https://github.com/nicklockwood/SwiftFormat", from: "0.50.5"),
18+
.package(url: "https://github.com/Realm/SwiftLint", from: "0.48.0"),
19+
.package(url: "https://github.com/pointfreeco/swift-snapshot-testing.git", from: "1.10.0"),
2020
.package(url: "https://github.com/shibapm/Rocket", from: "1.2.1"),
2121
] : []
2222
let devTargets: [Target] = isDevelop
2323
? [
24-
.testTarget(name: "DangerTests", dependencies: ["Danger", "DangerFixtures", "SnapshotTesting"]),
25-
.testTarget(name: "RunnerLibTests", dependencies: ["RunnerLib", "SnapshotTesting"], exclude: ["__Snapshots__"]),
26-
.testTarget(name: "DangerDependenciesResolverTests", dependencies: ["DangerDependenciesResolver", "SnapshotTesting"], exclude: ["__Snapshots__"]),
24+
.testTarget(name: "DangerTests",
25+
dependencies: [
26+
"Danger",
27+
"DangerFixtures",
28+
.product(name: "SnapshotTesting", package: "swift-snapshot-testing")
29+
]),
30+
.testTarget(name: "RunnerLibTests",
31+
dependencies: [
32+
"RunnerLib",
33+
.product(name: "SnapshotTesting", package: "swift-snapshot-testing")
34+
], exclude: ["__Snapshots__"]),
35+
.testTarget(name: "DangerDependenciesResolverTests",
36+
dependencies: [
37+
"DangerDependenciesResolver",
38+
.product(name: "SnapshotTesting", package: "swift-snapshot-testing")
39+
],
40+
exclude: ["__Snapshots__"]),
2741
]
2842
: []
2943

@@ -36,8 +50,8 @@ let package = Package(
3650
] + devProducts,
3751
dependencies: [
3852
.package(url: "https://github.com/shibapm/Logger", from: "0.1.0"),
39-
.package(url: "https://github.com/mxcl/Version", from: "2.0.0"),
40-
.package(name: "OctoKit", url: "https://github.com/nerdishbynature/octokit.swift", from: "0.11.0"),
53+
.package(url: "https://github.com/mxcl/Version", from: "2.0.1"),
54+
.package(name: "OctoKit", url: "https://github.com/nerdishbynature/octokit.swift", from: "0.12.0"),
4155
] + devDependencies,
4256
targets: [
4357
.target(name: "Danger-Swift", dependencies: ["Danger"]),

README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,13 @@ Write your Dangerfiles in Swift.
77

88
### Requirements
99

10-
Latest version requires Swift 5.4
10+
Latest version requires Swift 5.5
1111

1212
If you are using an older Swift, use the supported version according to next table.
1313

1414
| Swift version | Danger support version |
1515
| ------------- | ---------------------- |
16+
| 5.4 | v3.15.0 |
1617
| 5.3 | v3.13.0 |
1718
| 5.2 | v3.11.1 |
1819
| 5.1 | v3.8.0 |
@@ -182,7 +183,7 @@ jobs:
182183
steps:
183184
- uses: actions/checkout@v1
184185
- name: Danger
185-
uses: danger/swift@3.13.0
186+
uses: danger/swift@3.15.0
186187
with:
187188
args: --failOnErrors --no-publish-check
188189
env:
@@ -203,7 +204,7 @@ jobs:
203204
steps:
204205
- uses: actions/checkout@v1
205206
- name: Danger
206-
uses: docker://ghcr.io/danger/danger-swift:3.13.0
207+
uses: docker://ghcr.io/danger/danger-swift:3.15.0
207208
with:
208209
args: --failOnErrors --no-publish-check
209210
env:
@@ -231,7 +232,7 @@ swift run danger-swift command --cwd path/to/working-directory
231232

232233
#### Dev
233234

234-
You need to be using Xcode >= 11.3.1.
235+
You need to be using Xcode >= 13.2.1.
235236

236237
```sh
237238
git clone https://github.com/danger/danger-swift.git

Tests/DangerDependenciesResolverTests/XCTestManifests.swift

Lines changed: 0 additions & 57 deletions
This file was deleted.

Tests/DangerTests/SwiftLint/ViolationTests.swift

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,4 @@ final class ViolationTests: XCTestCase {
2121
XCTAssertEqual(subject.file, "/Users/ash/bin/Harvey/Sources/Harvey/Harvey.swift")
2222
XCTAssertEqual(subject.severity, .warning)
2323
}
24-
25-
static var allTests = [
26-
("testDecoding", testDecoding),
27-
]
2824
}

0 commit comments

Comments
 (0)