Merge pull request #596 from pouyayarandi/prevent-empty-swiftlint-response-from-failure

f-meloni · web-flow · commit f76cd15ca125 · 2023-11-06T05:16:17.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,8 @@
 
 ## Master
 
+- Prevent empty SwiftLint violation response from failure [@pouyayarandi][] - [#596](https://github.com/danger/swift/pull/596)
+
 ## 3.17.1
 
 - Use http tap url on update homebrew script [@f-meloni][]
diff --git a/Sources/Danger/Plugins/SwiftLint/SwiftLint.swift b/Sources/Danger/Plugins/SwiftLint/SwiftLint.swift
@@ -307,6 +307,9 @@ extension SwiftLint {
     }
 
     private static func makeViolations(from response: String, failAction: (String) -> Void) -> [SwiftLintViolation] {
+        guard !response.isEmpty else {
+            return []
+        }
         let decoder = JSONDecoder()
         do {
             let violations = try decoder.decode([SwiftLintViolation].self, from: Data(response.utf8))

Original file line number	Diff line number	Diff line change
`@@ -307,6 +307,9 @@ extension SwiftLint {`
`307`	`307`	`}`
`308`	`308`
`309`	`309`	`private static func makeViolations(from response: String, failAction: (String) -> Void) -> [SwiftLintViolation] {`
	`310`	`+ guard !response.isEmpty else {`
	`311`	`+ return []`
	`312`	`+ }`
`310`	`313`	`let decoder = JSONDecoder()`
`311`	`314`	`do {`
`312`	`315`	`let violations = try decoder.decode([SwiftLintViolation].self, from: Data(response.utf8))`