Skip to content

Commit 6ad1437

Browse files
committed
Remove .nvmrc
The `engines` entry in `package.json` should be enough for this project. `.nvmrc` doesn't give us as much flexibility in specifying a range of acceptable node versions (by design) and we don't want to mandate an arbitrary version for contributors using `nvm`. `.nvmrc` does provide some aliases and wildcards, like `node` for latest or `lts/*` for latest LTS, but it's still not quite what we want. I've added `.nvmrc` to `.gitignore` so if a contributor would like to add an `.nvmrc` for their own specific needs then they are welcome to do so for their local dev. fixes #97
1 parent 63189df commit 6ad1437

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

.gitignore

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,8 @@
11
/node_modules
2-
/lib
2+
/lib
3+
4+
# NVM users can add a local copy of .nvmrc if they want the auto-switching
5+
# behavior that NVM can provide. We'll ignore it at the project level because
6+
# we don't have a specific version requirement for dev besides what's listed
7+
# in package.json engines.
8+
/.nvmrc

.nvmrc

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)