build: validate only on pr builds and enable coverage comment (#2)

Author: daniel-makerx

.github/workflows/build-python.yaml

@@ -1,13 +1,6 @@
 name: Build and Test Python
 
-on:
-  workflow_call:
-    inputs:
-      coverageComment:
-        description: "Whether to add a comment on test coverage, default is false"
-        required: false
-        type: boolean
-        default: false # disabled for now        
+on: [workflow_call]
 
 jobs:
   build-python:
@@ -37,14 +30,12 @@ jobs:
       - name: pytest + coverage
         run: |
           set -o pipefail
-          poetry run pytest --junitxml=pytest.xml --cov-report=term-missing:skip-covered --cov=beaker | tee pytest-coverage.txt
+          poetry run pytest --cov-report xml --cov=beaker
 
-      - name: pytest coverage comment
-        if: inputs.coverageComment
-        uses: MishaKav/pytest-coverage-comment@main
+      - uses: codecov/codecov-action@v3
         with:
-          pytest-coverage-path: ./pytest-coverage.txt
-          junitxml-path: ./pytest.xml
+          files: ./coverage.xml
+          verbose: true
 
       - name: stop sandbox
         run: docker compose down

.github/workflows/cd.yaml

@@ -74,7 +74,7 @@ jobs:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Create Continuous Deployment - Beta (non-prod)
-        if: steps.get_branch.outputs.branch == 'master' && inputs.production_release
+        if: steps.get_branch.outputs.branch == 'master' && !inputs.production_release
         run: |
           poetry run semantic-release \
             -v DEBUG \

.github/workflows/validation.yaml .github/workflows/pr.yaml.github/workflows/validation.yaml renamed to .github/workflows/pr.yaml

@@ -1,10 +1,6 @@
 name: Pull Request and master validation
 
-on:
-  pull_request:
-  push:
-    branches:
-      - master
+on: [pull_request]
 
 jobs:
   check:
@@ -14,4 +10,4 @@ jobs:
   build:
     name: Build and Test Python
     needs: check
-    uses: ./.github/workflows/build-python.yaml
+    uses: ./.github/workflows/build-python.yaml