fix: handle whitespace correctly in attribute parsing and support reference attributes in angular templates

Author: daniel-sc

package.json

@@ -1,6 +1,6 @@
 {
   "name": "xml-trueformat",
-  "version": "0.9.3",
+  "version": "0.9.4",
   "description": "XML parser that 100% retains all formatting for creating identical XML on roundtrips",
   "main": "./dist/cjs/index.js",
   "module": "./dist/esm/index.mjs",

xmlParser.spec.ts

@@ -110,7 +110,7 @@ describe('XmlParser', () => {
       expect(nodes).toEqual([new XmlText('Hello, '), new XmlElement('my', [], [], ' ', true), new XmlText(' World!')]);
     });
     it('should parse angular template', () => {
-      const fragment = `<div someDirective></div>
+      const fragment = `<div someDirective #someRef></div>
   <app-radio-group [formControl]="control">
     <app-radio-button *ngFor="let item of dialogData.items" [value]="item">
       {{ displayLabel(item) }}
@@ -119,8 +119,10 @@ describe('XmlParser', () => {
   <button type="button" (click)="confirmChoice()" i18n="@@APPLY_BUTTON">OK</button>
 `;
       const nodes = XmlParser.parseFragment(fragment);
+
+      expect(nodes.map(n => n.toString()).join('')).toEqual(fragment);
       expect(nodes).toEqual([
-        new XmlElement('div', [new XmlAttribute('someDirective', '', ' ', '', '', '"', false)], [], ''),
+        new XmlElement('div', [new XmlAttribute('someDirective', '', ' ', '', '', '"', false), new XmlAttribute('#someRef', '', ' ', '', '', '"', false)], [], ''),
         new XmlText('\n  '),
         new XmlElement(
           'app-radio-group',

xmlParser.ts

@@ -140,7 +140,7 @@ export class XmlParser {
       if (attrName === '') {
         throw new Error(`Expected attribute name at position ${this.pos}`);
       }
-      const wsBeforeEqual = this.readWhitespace();
+      let wsBeforeEqual = this.readWhitespace();
       let wsAfterEqual = '';
       let quote = '"';
       let value = '';
@@ -163,6 +163,8 @@ export class XmlParser {
         }
       } else {
         hasValue = false;
+        this.pos -= wsBeforeEqual.length; // Rewind to before the whitespace
+        wsBeforeEqual = '';
       }
       attributes.push(
         new XmlAttribute(
@@ -229,7 +231,7 @@ export class XmlParser {
   // Reads a name (letters, digits, underscore, hyphen, colon, period).
   readName(): string {
     const start = this.pos;
-    while (this.pos < this.input.length && /[A-Za-z0-9_\-.:\[\]*()]/.test(this.input[this.pos])) {
+    while (this.pos < this.input.length && /[A-Za-z0-9_\-.:\[\]*()#]/.test(this.input[this.pos])) {
       this.pos++;
     }
     return this.input.substring(start, this.pos);