Move sync file write to only happen after unzip fail

Author: danielbotros

robot/packages/cloud_package_manager.go

@@ -193,16 +193,6 @@ func (m *cloudManager) Sync(ctx context.Context, packages []config.PackageConfig
 			m.logger.Errorf("Failed downloading package %s:%s from %s, %s", p.Package, p.Version, sanitizeURLForLogs(resp.Package.Url), err)
 			outErr = multierr.Append(outErr, fmt.Errorf("failed downloading package %s:%s from %s %w",
 				p.Package, p.Version, sanitizeURLForLogs(resp.Package.Url), err))
-
-			statusFile := packageSyncFile{
-				PackageID:       p.Package,
-				Version:         p.Version,
-				ModifiedTime:    time.Now(),
-				Status:          syncStatusFailed,
-				TarballChecksum: "",
-			}
-			err = writeStatusFile(p, statusFile, m.packagesDir)
-			outErr = multierr.Append(outErr, err)
 			continue
 		}
 

robot/packages/utils.go

@@ -82,6 +82,14 @@ func installPackage(
 	// unzip archive.
 	err = unpackFile(ctx, dstPath, tmpDataPath)
 	if err != nil {
+		statusFile := packageSyncFile{
+			PackageID:       p.Package,
+			Version:         p.Version,
+			ModifiedTime:    time.Now(),
+			Status:          syncStatusFailed,
+			TarballChecksum: "",
+		}
+		utils.UncheckedError(writeStatusFile(p, statusFile, packagesDir))
 		utils.UncheckedError(cleanup(packagesDir, p))
 		return err
 	}