Fix/remove node link scu methods (#18)

* Remove unecessary shouldComponentUpdate implementations

* Fix small lint issue

* Small fix on hardcoded value

Author: danielcaldas

.eslintrc.js

@@ -25,7 +25,7 @@ module.exports = {
         "camelcase": "error",
         "keyword-spacing": "error",
         "max-len": ["error", 120, 4, { "ignoreComments": true }],
-        "max-lines": ["error", {"max": 250, "skipComments": true}],
+        "max-lines": ["error", {"max": 300, "skipComments": true}],
         "newline-after-var": ["error", "always"],
         "no-nested-ternary": "error",
         "no-useless-constructor": "error",

package.json

@@ -14,7 +14,7 @@
         "docs": "npm run docs:lint && node_modules/documentation/bin/documentation.js build src/**/*.js -f html -o gen-docs && node_modules/documentation/bin/documentation.js build src/**/*.js -f md > gen-docs/DOCUMENTATION.md",
         "docs:lint": "node_modules/documentation/bin/documentation.js lint src/**/*.js",
         "docs:watch": "node_modules/documentation/bin/documentation.js build src/**/*.js -f html -o gen-docs --watch",
-        "lint": "node_modules/eslint/bin/eslint.js --config=.eslintrc.js \"src/**/*.js\"",
+        "lint": "node_modules/eslint/bin/eslint.js --config=.eslintrc.js \"src/**/*.js*\"",
         "test": "jest --verbose --coverage",
         "test:clean": "jest --no-cache --updateSnapshot --verbose --coverage",
         "test:watch": "jest --verbose --watchAll"

src/components/Graph/helper.jsx

@@ -98,7 +98,16 @@ function _buildNodeLinks(nodeId, nodes, links, config, linkCallbacks, someNodeHi
 
             if (nodes[target]) {
                 const key = `${nodeId}${CONST.COORDS_SEPARATOR}${target}`;
-                const props = _buildLinkProps(source, target, nodes, links, config, linkCallbacks, someNodeHighlighted, transform);
+                const props = _buildLinkProps(
+                    source,
+                    target,
+                    nodes,
+                    links,
+                    config,
+                    linkCallbacks,
+                    someNodeHighlighted,
+                    transform
+                );
 
                 linksComponents.push(<Link key={key} {...props} />);
             }

src/components/Link/index.jsx

@@ -27,16 +27,6 @@ export default class Link extends React.Component {
      */
     handleOnClickLink = () => this.props.onClickLink && this.props.onClickLink(this.props.source, this.props.target);
 
-    shouldComponentUpdate(nextProps) {
-        // Properties more likely to mutate are evaluated first to take advantage of short-circuit evaluation
-        return nextProps.x1 !== this.props.x1 || nextProps.y1 !== this.props.y1
-            || nextProps.x2 !== this.props.x2 || nextProps.y2 !== this.props.y2
-            || nextProps.opacity !== this.props.opacity
-            || nextProps.stroke !== this.props.stroke
-            || nextProps.strokeWidth !== this.props.strokeWidth
-            || nextProps.color !== this.props.color;
-    }
-
     render() {
         const lineStyle = {
             strokeWidth: this.props.strokeWidth,

src/components/Node/const.js

@@ -3,6 +3,7 @@ export default {
         START_ANGLE: 0,
         END_ANGLE: 2 * Math.PI
     },
+    DEFAULT_NODE_SIZE: 80, // FIXME: This value should come from ../Graph/config.js
     NODE_LABEL_DX: '.90em',
     NODE_LABEL_DY: '.35em',
     SYMBOLS: {

src/components/Node/helper.js

@@ -53,7 +53,7 @@ function _convertTypeToD3Symbol(typeName) {
  * @return {Object} concrete instance of d3 symbol.
  * @memberof Node/helper
  */
-function buildSvgSymbol(size=80, symbolTypeDesc=CONST.SYMBOLS.CIRCLE) {
+function buildSvgSymbol(size=CONST.DEFAULT_NODE_SIZE, symbolTypeDesc=CONST.SYMBOLS.CIRCLE) {
     return d3Symbol()
             .size(() => size)
             .type(() => _convertTypeToD3Symbol(symbolTypeDesc))(); // @todo: Strange behavior Symbol ret function

src/components/Node/index.jsx

@@ -58,22 +58,6 @@ export default class Node extends React.Component {
      */
     handleOnMouseOutNode = () => this.props.onMouseOut && this.props.onMouseOut(this.props.id);
 
-    shouldComponentUpdate(nextProps) {
-        // Properties more likely to mutate are evaluated first to take advantage of short-circuit evaluation
-        return nextProps.cx !== this.props.cx || nextProps.cy !== this.props.cy
-              || nextProps.opacity !== this.props.opacity
-              || nextProps.fill !== this.props.fill
-              || nextProps.fontWeight !== this.props.fontWeight
-              || nextProps.fontSize !== this.props.fontSize
-              || nextProps.label !== this.props.label
-              || nextProps.cursor !== this.props.cursor
-              || nextProps.size !== this.props.size
-              || nextProps.type !== this.props.type
-              || nextProps.renderLabel !== this.props.renderLabel
-              || nextProps.stroke !== this.props.stroke
-              || nextProps.strokeWidth !== this.props.strokeWidth;
-    }
-
     render() {
         const gProps = {
             className: this.props.className,