I have #40
Open
I have #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<div range-slider show-values="true" min="refinement.children[0].name" max="refinement.children[refinement.children.length-1].name" model-min="vm.selPubYearRange.min" model-max="vm.selPubYearRange.max" ></div> refinement.children[0].name is considered a string not a number and hence scope.modelMin = parseFloat((((proposal * range) / 100) + (scope.min)).toFixed(scope.decimalPlaces); is concatinating the values "parseFloat((((proposal * range) / 100)" and "(scope.min)" instead of adding them so changed it scope.min to int before adding.
|
What if scope.min is not an integer...? Wouldn't Do we also need to apply the same change to modelMax? |
|
You are right it should be parseFloat :-). modelMax is not causing any problems, may be because there is no arithmetic However as the code is definitely expecting these variables to be float, I On Mon, Nov 24, 2014 at 4:40 AM, danielcrisp [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refinement.children[0].name is considered a string not a number and hence
scope.modelMin = parseFloat((((proposal * range) / 100) + (scope.min)).toFixed(scope.decimalPlaces);
is concatinating the values "parseFloat((((proposal * range) / 100)" and "(scope.min)" instead of adding them
so changed it scope.min to int before adding.