Merge pull request #1 from danieldanilov/retroactive-learnings

Retroactive learnings: change "created at" to "learned on" and also update localhost to use port 8000 to avoid conflicts

Author: danieldanilov

.github/workflows/ci.yml

@@ -22,22 +22,6 @@ jobs:
       - name: Scan for common Rails security vulnerabilities using static analysis
         run: bin/brakeman --no-pager
 
-  scan_js:
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
-
-      - name: Set up Ruby
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: .ruby-version
-          bundler-cache: true
-
-      - name: Scan for security vulnerabilities in JavaScript dependencies
-        run: bin/importmap audit
-
   lint:
     runs-on: ubuntu-latest
     steps:
@@ -51,5 +35,5 @@ jobs:
           bundler-cache: true
 
       - name: Lint code for consistent style
-        run: bin/rubocop -f github
+        run: bundle exec rubocop
 

Gemfile

@@ -49,7 +49,7 @@ group :development, :test do
   gem "brakeman", require: false
 
   # Omakase Ruby styling [https://github.com/rails/rubocop-rails-omakase/]
-  # gem "rubocop-rails-omakase", require: false
+  gem "rubocop-rails-omakase", require: false
 end
 
 group :development do

Gemfile.lock

@@ -72,6 +72,7 @@ GEM
       securerandom (>= 0.3)
       tzinfo (~> 2.0, >= 2.0.5)
       uri (>= 0.13.1)
+    ast (2.4.3)
     base64 (0.2.0)
     benchmark (0.4.0)
     bigdecimal (3.1.9)
@@ -104,6 +105,9 @@ GEM
       pp (>= 0.6.0)
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
+    json (2.10.2)
+    language_server-protocol (3.17.0.4)
+    lint_roller (1.1.0)
     logger (1.7.0)
     loofah (2.24.0)
       crass (~> 1.0.2)
@@ -143,10 +147,15 @@ GEM
       racc (~> 1.4)
     nokogiri (1.18.7-x86_64-linux-musl)
       racc (~> 1.4)
+    parallel (1.26.3)
+    parser (3.3.7.4)
+      ast (~> 2.4.1)
+      racc
     pg (1.5.9)
     pp (0.6.2)
       prettyprint
     prettyprint (0.2.0)
+    prism (1.4.0)
     propshaft (1.1.0)
       actionpack (>= 7.0.0)
       activesupport (>= 7.0.0)
@@ -195,9 +204,11 @@ GEM
       rake (>= 12.2)
       thor (~> 1.0, >= 1.2.2)
       zeitwerk (~> 2.6)
+    rainbow (3.1.1)
     rake (13.2.1)
     rdoc (6.13.1)
       psych (>= 4.0.0)
+    regexp_parser (2.10.0)
     reline (0.6.1)
       io-console (~> 0.5)
     rspec-core (3.13.3)
@@ -217,6 +228,35 @@ GEM
       rspec-mocks (~> 3.13)
       rspec-support (~> 3.13)
     rspec-support (3.13.2)
+    rubocop (1.75.2)
+      json (~> 2.3)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
+      parallel (~> 1.10)
+      parser (>= 3.3.0.2)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.44.0, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.44.1)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
+    rubocop-performance (1.25.0)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rails (2.31.0)
+      activesupport (>= 4.2.0)
+      lint_roller (~> 1.1)
+      rack (>= 1.1)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rails-omakase (1.1.0)
+      rubocop (>= 1.72)
+      rubocop-performance (>= 1.24)
+      rubocop-rails (>= 2.30)
+    ruby-progressbar (1.13.0)
     securerandom (0.4.1)
     solid_cache (1.0.7)
       activejob (>= 7.2)
@@ -237,6 +277,9 @@ GEM
       railties (>= 7.1.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
+    unicode-display_width (3.1.4)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
     uri (1.0.3)
     useragent (0.16.11)
     web-console (4.2.1)
@@ -272,6 +315,7 @@ DEPENDENCIES
   puma (>= 5.0)
   rails (~> 8.0.2)
   rspec-rails (>= 6.0)
+  rubocop-rails-omakase
   solid_cache
   stimulus-rails
   thruster

README.md

@@ -43,7 +43,7 @@ It also serves as a self-referential job application, demonstrating core Rails s
   ```bash
   rbenv exec bin/dev
   ```
-  Visit `http://localhost:3000` in your browser.
+  Visit `http://localhost:8000` in your browser.
 
 ## Running Tests
 

app/controllers/learnings_controller.rb

@@ -1,6 +1,6 @@
 class LearningsController < ApplicationController
   def index
-    @learnings = Learning.order(created_at: :desc)
+    @learnings = Learning.order(learned_on: :desc)
   end
 
   def new
@@ -32,6 +32,6 @@ def destroy_multiple
   private
 
   def learning_params
-    params.require(:learning).permit(:title, :body, :tags)
+    params.require(:learning).permit(:title, :body, :tags, :learned_on)
   end
 end

app/views/learnings/index.html.erb

@@ -18,7 +18,7 @@
             <% if learning.tags.present? %>
               <p><strong>Tags:</strong> <%= learning.tags %></p>
             <% end %>
-            <small>Logged on: <%= learning.created_at.strftime("%B %d, %Y") %></small>
+            <small>Learned on: <%= learning.learned_on.strftime("%B %d, %Y") %></small>
           </div>
         </label>
       <% end %>

app/views/learnings/new.html.erb

@@ -22,6 +22,11 @@
     <%= form.text_area :body, rows: 5 %>
   </div>
 
+  <div>
+    <%= form.label :learned_on, "Learned On" %><br>
+    <%= form.date_field :learned_on, value: Date.today %>
+  </div>
+
   <div>
     <%= form.label :tags, "Tags (comma-separated)" %><br>
     <%= form.text_field :tags %>

config/environments/development.rb

@@ -38,7 +38,7 @@
   config.action_mailer.perform_caching = false
 
   # Set localhost to be used by links generated in mailer templates.
-  config.action_mailer.default_url_options = { host: "localhost", port: 3000 }
+  config.action_mailer.default_url_options = { host: "localhost", port: 8000 }
 
   # Print deprecation notices to the Rails logger.
   config.active_support.deprecation = :log

config/puma.rb

@@ -28,7 +28,7 @@
 threads threads_count, threads_count
 
 # Specifies the `port` that Puma will listen on to receive requests; default is 3000.
-port ENV.fetch("PORT", 3000)
+port ENV.fetch("PORT", 8000)
 
 # Allow puma to be restarted by `bin/rails restart` command.
 plugin :tmp_restart

config/routes.rb

@@ -13,7 +13,7 @@
   get "about", to: "static_pages#about"
 
   # Learning Resources (only index, new, create)
-  resources :learnings, only: [:index, :new, :create] do
+  resources :learnings, only: [ :index, :new, :create ] do
     delete :destroy_multiple, on: :collection
   end