feat!: Allow compiling with stable toolchain (#64)

* remove associated type defaults

* add MSRV check to CI

Author: danieleades

.github/workflows/CI.yml

@@ -44,3 +44,17 @@ jobs:
     steps:
     - uses: actions/checkout@v4
     - uses: EmbarkStudios/cargo-deny-action@v1
+
+  msrv:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@master
+      - name: Get MSRV from Cargo.toml
+        run: |
+          MSRV=$(grep 'rust-version' Cargo.toml | sed 's/.*= *"\(.*\)".*/\1/')
+          echo "MSRV=$MSRV" >> $GITHUB_ENV
+      - uses: dtolnay/rust-toolchain@master
+        with:
+          toolchain: ${{ env.MSRV }}
+      - uses: taiki-e/install-action@cargo-no-dev-deps
+      - run: cargo no-dev-deps check --all

Cargo.toml

@@ -1,16 +1,14 @@
-[package]
-name = "arithmetic-coding"
-description = "fast and flexible arithmetic coding library"
-version = "0.3.1"
+[workspace]
+members = [".", "arithmetic-coding-core", "fenwick-model"]
+
+[workspace.package]
+rust-version = "1.79.0"
 edition = "2021"
 license = "MIT"
 keywords = ["compression", "encoding", "arithmetic-coding", "lossless"]
 categories = ["compression", "encoding", "parsing"]
 repository = "https://github.com/danieleades/arithmetic-coding"
 
-[workspace]
-members = [".", "arithmetic-coding-core", "fenwick-model"]
-
 [workspace.dependencies]
 thiserror = "1.0.30"
 
@@ -20,6 +18,17 @@ all = "deny"
 nursery = "warn"
 pedantic = "warn"
 
+[package]
+name = "arithmetic-coding"
+description = "fast and flexible arithmetic coding library"
+version = "0.3.1"
+edition.workspace = true
+license.workspace = true
+keywords.workspace = true
+categories.workspace = true
+repository.workspace = true
+rust-version.workspace = true
+
 [dependencies]
 arithmetic-coding-core = { path = "./arithmetic-coding-core", version = "0.3.0" }
 bitstream-io = "2.0.0"

arithmetic-coding-core/Cargo.toml

@@ -2,13 +2,12 @@
 name = "arithmetic-coding-core"
 description = "core traits for the 'arithmetic-coding' crate"
 version = "0.3.0"
-edition = "2021"
-license = "MIT"
-keywords = ["compression", "encoding", "arithmetic-coding", "lossless"]
-categories = ["compression", "encoding", "parsing"]
-repository = "https://github.com/danieleades/arithmetic-coding"
-
-# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+edition.workspace = true
+license.workspace = true
+keywords.workspace = true
+categories.workspace = true
+repository.workspace = true
+rust-version.workspace = true
 
 [dependencies]
 thiserror = { workspace = true }

arithmetic-coding-core/src/lib.rs

@@ -1,7 +1,6 @@
 //! Core traits for the [`arithmetic-coding`](https://github.com/danieleades/arithmetic-coding) crate
 
 #![deny(missing_docs, missing_debug_implementations)]
-#![feature(associated_type_defaults)]
 
 mod bitstore;
 pub use bitstore::BitStore;

arithmetic-coding-core/src/model.rs

@@ -30,6 +30,7 @@ pub mod one_shot;
 /// pub struct MyModel;
 ///
 /// impl Model for MyModel {
+///     type B = u32;
 ///     type Symbol = Symbol;
 ///     type ValueError = !;
 ///
@@ -65,7 +66,7 @@ pub trait Model {
     type ValueError: Error;
 
     /// The internal representation to use for storing integers
-    type B: BitStore = u32;
+    type B: BitStore;
 
     /// Given a symbol, return an interval representing the probability of that
     /// symbol occurring.

arithmetic-coding-core/src/model/fixed_length.rs

@@ -20,7 +20,6 @@ use crate::BitStore;
 /// # Example
 ///
 /// ```
-/// #![feature(exclusive_range_pattern)]
 /// #![feature(never_type)]
 /// # use std::ops::Range;
 /// #
@@ -35,6 +34,7 @@ use crate::BitStore;
 /// pub struct MyModel;
 ///
 /// impl fixed_length::Model for MyModel {
+///     type B = u32;
 ///     type Symbol = Symbol;
 ///     type ValueError = !;
 ///
@@ -72,7 +72,7 @@ pub trait Model {
     type ValueError: std::error::Error;
 
     /// The internal representation to use for storing integers
-    type B: BitStore = u32;
+    type B: BitStore;
 
     /// Given a symbol, return an interval representing the probability of that
     /// symbol occurring.

arithmetic-coding-core/src/model/max_length.rs

@@ -22,7 +22,6 @@ use crate::BitStore;
 /// # Example
 ///
 /// ```
-/// #![feature(exclusive_range_pattern)]
 /// #![feature(never_type)]
 /// # use std::ops::Range;
 /// #
@@ -37,6 +36,7 @@ use crate::BitStore;
 /// pub struct MyModel;
 ///
 /// impl max_length::Model for MyModel {
+///     type B = u32;
 ///     type Symbol = Symbol;
 ///     type ValueError = !;
 ///
@@ -76,7 +76,7 @@ pub trait Model {
     type ValueError: std::error::Error;
 
     /// The internal representation to use for storing integers
-    type B: BitStore = u32;
+    type B: BitStore;
 
     /// Given a symbol, return an interval representing the probability of that
     /// symbol occurring.

arithmetic-coding-core/src/model/one_shot.rs

@@ -23,7 +23,6 @@ use crate::{fixed_length, BitStore};
 /// # Example
 ///
 /// ```
-/// #![feature(exclusive_range_pattern)]
 /// #![feature(never_type)]
 /// # use std::ops::Range;
 /// #
@@ -38,6 +37,7 @@ use crate::{fixed_length, BitStore};
 /// pub struct MyModel;
 ///
 /// impl one_shot::Model for MyModel {
+///     type B = u32;
 ///     type Symbol = Symbol;
 ///     type ValueError = !;
 ///
@@ -71,7 +71,7 @@ pub trait Model {
     type ValueError: std::error::Error;
 
     /// The internal representation to use for storing integers
-    type B: BitStore = u32;
+    type B: BitStore;
 
     /// Given a symbol, return an interval representing the probability of that
     /// symbol occurring.

examples/concatenated.rs

@@ -16,6 +16,7 @@ mod integer {
     pub struct Error(u8);
 
     impl arithmetic_coding::Model for Model {
+        type B = u32;
         type Symbol = u8;
         type ValueError = Error;
 
@@ -58,6 +59,7 @@ mod symbolic {
     pub struct Model;
 
     impl arithmetic_coding::Model for Model {
+        type B = u32;
         type Symbol = Symbol;
         type ValueError = !;
 

examples/fixed_length.rs

@@ -17,6 +17,7 @@ pub enum Symbol {
 pub struct MyModel;
 
 impl fixed_length::Model for MyModel {
+    type B = u32;
     type Symbol = Symbol;
     type ValueError = !;