Skip to content

Commit 6ee54cd

Browse files
committed
cleanup warnings
1 parent 0f57081 commit 6ee54cd

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed

src/providers/WorkflowCore.LockProviders.SqlServer/SqlLockProvider.cs

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -133,12 +133,9 @@ public async Task ReleaseLock(string Id)
133133
}
134134
}
135135

136-
public async Task Start()
137-
{
138-
}
139-
140-
public async Task Stop()
141-
{
142-
}
136+
public Task Start() => Task.CompletedTask;
137+
138+
public Task Stop() => Task.CompletedTask;
139+
143140
}
144141
}

src/providers/WorkflowCore.Providers.Azure/Services/AzureLockManager.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,15 @@ public async Task Start()
9393
_renewTimer = new Timer(RenewLeases, null, RenewInterval, RenewInterval);
9494
}
9595

96-
public async Task Stop()
96+
public Task Stop()
9797
{
9898
if (_renewTimer == null)
99-
return;
99+
return Task.CompletedTask;
100100

101101
_renewTimer.Dispose();
102102
_renewTimer = null;
103+
104+
return Task.CompletedTask;
103105
}
104106

105107
private async void RenewLeases(object state)

src/providers/WorkflowCore.Providers.Redis/Services/RedisPersistenceProvider.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public async Task<IEnumerable<string>> GetRunnableInstances(DateTime asAt)
7070
return result;
7171
}
7272

73-
public async Task<IEnumerable<WorkflowInstance>> GetWorkflowInstances(WorkflowStatus? status, string type, DateTime? createdFrom, DateTime? createdTo, int skip,
73+
public Task<IEnumerable<WorkflowInstance>> GetWorkflowInstances(WorkflowStatus? status, string type, DateTime? createdFrom, DateTime? createdTo, int skip,
7474
int take)
7575
{
7676
throw new NotImplementedException();

0 commit comments

Comments
 (0)