cleanup exceptions

Author: danielgerlag

src/WorkflowCore/Exceptions/CorruptPersistenceDataException.cs

@@ -0,0 +1,10 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace WorkflowCore.Exceptions
+{
+    public class CorruptPersistenceDataException : Exception
+    {
+    }
+}

src/WorkflowCore/Exceptions/WorkflowNotRegisteredException.cs

@@ -0,0 +1,14 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace WorkflowCore.Exceptions
+{
+    public class WorkflowNotRegisteredException : Exception
+    {
+        public WorkflowNotRegisteredException(string workflowId, int? version)
+            : base($"Workflow {workflowId} {version} is not registered")
+        {
+        }
+    }
+}

src/WorkflowCore/Primitives/If.cs

@@ -4,6 +4,7 @@
 using System.Collections.Generic;
 using System.Linq.Expressions;
 using System.Text;
+using WorkflowCore.Exceptions;
 using WorkflowCore.Interface;
 using WorkflowCore.Models;
 
@@ -35,7 +36,7 @@ public override ExecutionResult Run(IStepExecutionContext context)
                     return ExecutionResult.Persist(context.PersistenceData);
             }
 
-            throw new Exception("Corrupt persistence data");
+            throw new CorruptPersistenceDataException();
         }        
     }
 }

src/WorkflowCore/Primitives/OutcomeSwitch.cs

@@ -4,6 +4,7 @@
 using System.Collections.Generic;
 using System.Linq.Expressions;
 using System.Text;
+using WorkflowCore.Exceptions;
 using WorkflowCore.Interface;
 using WorkflowCore.Models;
 
@@ -36,7 +37,7 @@ public override ExecutionResult Run(IStepExecutionContext context)
                 }
             }
 
-            throw new Exception("Corrupt persistence data");
+            throw new CorruptPersistenceDataException();
         }
 
         private object GetPreviousOutcome(IStepExecutionContext context)

src/WorkflowCore/Primitives/Sequence.cs

@@ -4,6 +4,7 @@
 using System.Collections.Generic;
 using System.Linq.Expressions;
 using System.Text;
+using WorkflowCore.Exceptions;
 using WorkflowCore.Interface;
 using WorkflowCore.Models;
 
@@ -28,7 +29,7 @@ public override ExecutionResult Run(IStepExecutionContext context)
                     return ExecutionResult.Persist(context.PersistenceData);
             }
 
-            throw new Exception("Corrupt persistence data");
+            throw new CorruptPersistenceDataException();
         }        
     }
 }

src/WorkflowCore/Primitives/When.cs

@@ -4,6 +4,7 @@
 using System.Collections.Generic;
 using System.Linq.Expressions;
 using System.Text;
+using WorkflowCore.Exceptions;
 using WorkflowCore.Interface;
 using WorkflowCore.Models;
 
@@ -38,7 +39,7 @@ public override ExecutionResult Run(IStepExecutionContext context)
                     return ExecutionResult.Persist(context.PersistenceData);
             }
 
-            throw new Exception("Corrupt persistence data");
+            throw new CorruptPersistenceDataException();
         }        
 
         private object GetSwitchOutcome(IStepExecutionContext context)

src/WorkflowCore/Primitives/While.cs

@@ -4,6 +4,7 @@
 using System.Collections.Generic;
 using System.Linq.Expressions;
 using System.Text;
+using WorkflowCore.Exceptions;
 using WorkflowCore.Interface;
 using WorkflowCore.Models;
 
@@ -35,7 +36,7 @@ public override ExecutionResult Run(IStepExecutionContext context)
                     return ExecutionResult.Persist(context.PersistenceData);
             }
 
-            throw new Exception("Corrupt persistence data");
+            throw new CorruptPersistenceDataException();
         }        
     }
 }

src/WorkflowCore/Services/FluentBuilders/StepBuilder.cs

@@ -145,10 +145,10 @@ public IStepBuilder<TData, TStep> End<TStep>(string name) where TStep : IStepBod
             var ancestor = IterateParents(Step.Id, name);
 
             if (ancestor == null)
-                throw new Exception(String.Format("Parent step of name {0} not found", name));
+                throw new InvalidOperationException($"Parent step of name {name} not found");
 
             if (!(ancestor is WorkflowStep<TStep>))
-                throw new Exception(String.Format("Parent step of name {0} is not of type {1}", name, typeof(TStep)));
+                throw new InvalidOperationException($"Parent step of name {name} is not of type {typeof(TStep)}");
 
             return new StepBuilder<TData, TStep>(WorkflowBuilder, (ancestor as WorkflowStep<TStep>));
         }

src/WorkflowCore/Services/WorkflowHost.cs

@@ -8,6 +8,7 @@
 using WorkflowCore.Interface;
 using WorkflowCore.Models;
 using System.Reflection;
+using WorkflowCore.Exceptions;
 
 namespace WorkflowCore.Services
 {
@@ -61,11 +62,11 @@ public async Task<string> StartWorkflow<TData>(string workflowId, int? version,
             where TData : class
         {
             if (_shutdown)
-                throw new Exception("Host is not running");
+                throw new InvalidOperationException("Host is not running");
 
             var def = Registry.GetDefinition(workflowId, version);
             if (def == null)
-                throw new Exception(String.Format("Workflow {0} version {1} is not registered", workflowId, version));
+                throw new WorkflowNotRegisteredException(workflowId, version);
 
             var wf = new WorkflowInstance();
             wf.WorkflowDefinitionId = workflowId;
@@ -121,7 +122,7 @@ public void Stop()
         public async Task PublishEvent(string eventName, string eventKey, object eventData, DateTime? effectiveDate = null)
         {
             if (_shutdown)
-                throw new Exception("Host is not running");
+                throw new InvalidOperationException("Host is not running");
 
             Logger.LogDebug("Creating event {0} {1}", eventName, eventKey);
             Event evt = new Event();

src/WorkflowCore/Services/WorkflowRegistry.cs

@@ -11,7 +11,7 @@ public class WorkflowRegistry : IWorkflowRegistry
     {
 
         private readonly IServiceProvider _serviceProvider;
-        private List<Tuple<string, int, WorkflowDefinition>> _registry = new List<Tuple<string, int, WorkflowDefinition>>();
+        private readonly List<Tuple<string, int, WorkflowDefinition>> _registry = new List<Tuple<string, int, WorkflowDefinition>>();
 
         public WorkflowRegistry(IServiceProvider serviceProvider)
         {
@@ -40,7 +40,7 @@ public WorkflowDefinition GetDefinition(string workflowId, int? version = null)
         public void RegisterWorkflow(IWorkflow workflow)
         {
             if (_registry.Any(x => x.Item1 == workflow.Id && x.Item2 == workflow.Version))
-                throw new Exception(String.Format("Workflow {0} version {1} is already registered", workflow.Id, workflow.Version));
+                throw new InvalidOperationException($"Workflow {workflow.Id} version {workflow.Version} is already registered");
 
             var builder = (_serviceProvider.GetService(typeof(IWorkflowBuilder)) as IWorkflowBuilder).UseData<object>();            
             workflow.Build(builder);
@@ -52,7 +52,7 @@ public void RegisterWorkflow<TData>(IWorkflow<TData> workflow)
             where TData : new()
         {
             if (_registry.Any(x => x.Item1 == workflow.Id && x.Item2 == workflow.Version))
-                throw new Exception(String.Format("Workflow {0} version {1} is already registed", workflow.Id, workflow.Version));
+                throw new InvalidOperationException($"Workflow {workflow.Id} version {workflow.Version} is already registed");
 
             var builder = (_serviceProvider.GetService(typeof(IWorkflowBuilder)) as IWorkflowBuilder).UseData<TData>();
             workflow.Build(builder);