Skip to content

Commit 91ee43d

Browse files
Fix greylist foerever stack issue
1 parent 2746d05 commit 91ee43d

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

src/WorkflowCore/Services/BackgroundTasks/EventConsumer.cs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,13 @@ protected override async Task ProcessItem(string itemId, CancellationToken cance
7474
complete = complete && await SeedSubscription(evt, sub, toQueue, cancellationToken);
7575

7676
if (complete)
77+
{
7778
await _eventRepository.MarkEventProcessed(itemId, cancellationToken);
79+
}
80+
else
81+
{
82+
_greylist.Remove($"evt:{evt.Id}");
83+
}
7884

7985
foreach (var eventId in toQueue)
8086
await QueueProvider.QueueWork(eventId, QueueType.Event);
@@ -87,7 +93,7 @@ protected override async Task ProcessItem(string itemId, CancellationToken cance
8793
}
8894

8995
private async Task<bool> SeedSubscription(Event evt, EventSubscription sub, HashSet<string> toQueue, CancellationToken cancellationToken)
90-
{
96+
{
9197
foreach (var eventId in await _eventRepository.GetEvents(sub.EventName, sub.EventKey, sub.SubscribeAsOf, cancellationToken))
9298
{
9399
if (eventId == evt.Id)

src/WorkflowCore/Services/BackgroundTasks/RunnablePoller.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ private async void PollRunnables(object target)
9393
if (_greylist.Contains($"evt:{item}"))
9494
{
9595
_logger.LogDebug($"Got greylisted event {item}");
96-
_greylist.Add($"evt:{item}");
9796
continue;
9897
}
9998
_logger.LogDebug($"Got unprocessed event {item}");

0 commit comments

Comments
 (0)