tpl refinements

Author: danielgerlag

src/WorkflowCore/Models/WorkflowOptions.cs

@@ -20,7 +20,7 @@ public WorkflowOptions()
         {
             //set defaults
             PollInterval = TimeSpan.FromSeconds(10);
-            IdleTime = TimeSpan.FromMilliseconds(100);
+            IdleTime = TimeSpan.FromMilliseconds(500);
             ErrorRetryInterval = TimeSpan.FromSeconds(60);            
 
             QueueFactory = new Func<IServiceProvider, IQueueProvider>(sp => new SingleNodeQueueProvider());

src/WorkflowCore/Services/WorkflowTask.cs

@@ -16,7 +16,7 @@ class WorkflowTask : IBackgroundTask
         private readonly IWorkflowExecutor _executor;
         private readonly IQueueProvider _queueProvider;
         private readonly ILogger _logger;
-        private readonly Task _task;
+        private readonly IList<Task> _tasks;
         private readonly WorkflowOptions _options;
         private readonly IDateTimeProvider _datetimeProvider;
         private bool _shutdown = true;
@@ -29,21 +29,27 @@ public WorkflowTask(IPersistenceProvider persistenceStore, IQueueProvider queueP
             _options = options;
             _logger = loggerFactory.CreateLogger<WorkflowTask>();
             _lockProvider = lockProvider;
-            _task = new Task(RunWorkflows);
+
+            _tasks = new List<Task>();
+            for (int i = 0; i < Environment.ProcessorCount; i++)
+                _tasks.Add(new Task(RunWorkflows));
+
             _datetimeProvider = datetimeProvider;
             persistenceStore.EnsureStoreExists();
         }
 
         public void Start()
         {
             _shutdown = false;
-            _task.Start();
+            foreach (var task in _tasks)
+                task.Start();
         }
 
         public void Stop()
         {
             _shutdown = true;
-            _task.Wait();
+            foreach (var task in _tasks)
+                task.Wait();
         }
 
         /// <summary>
@@ -56,8 +62,9 @@ private async void RunWorkflows()
                 try
                 {
                     var workflowId = await _queueProvider.DequeueWork(QueueType.Workflow);
+                    
                     if (workflowId != null)
-                        Parallel.Invoke(() => ProcessWorkflow(workflowId));
+                        await ProcessWorkflow(workflowId);
                     else
                         await Task.Delay(_options.IdleTime);  //no work
                 }
@@ -68,7 +75,7 @@ private async void RunWorkflows()
             }
         }
 
-        private async void ProcessWorkflow(string workflowId)
+        private async Task ProcessWorkflow(string workflowId)
         {
             try
             {

src/WorkflowCore/WorkflowCore.csproj

@@ -18,9 +18,9 @@
     <GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
     <GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
     <Description>Workflow Core is a light weight workflow engine targeting .NET Standard.</Description>
-    <Version>1.2.9</Version>
-    <AssemblyVersion>1.2.9.0</AssemblyVersion>
-    <FileVersion>1.2.9.0</FileVersion>
+    <Version>1.3.0</Version>
+    <AssemblyVersion>1.3.0.0</AssemblyVersion>
+    <FileVersion>1.3.0.0</FileVersion>
     <PackageReleaseNotes></PackageReleaseNotes>
   </PropertyGroup>
 

src/extensions/WorkflowCore.Users/WorkflowCore.Users.csproj

@@ -18,9 +18,9 @@
     <GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
     <GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
     <Description>Provides extensions for Workflow Core to enable human workflows.</Description>
-    <Version>1.2.9</Version>
-    <AssemblyVersion>1.2.9.0</AssemblyVersion>
-    <FileVersion>1.2.9.0</FileVersion>
+    <Version>1.3.0</Version>
+    <AssemblyVersion>1.3.0.0</AssemblyVersion>
+    <FileVersion>1.3.0.0</FileVersion>
   </PropertyGroup>
 
   <ItemGroup>

src/samples/WorkflowCore.Sample03/Program.cs

@@ -26,6 +26,7 @@ public static void Main(string[] args)
             initialData.Value2 = 3;
 
             host.StartWorkflow("PassingDataWorkflow", 1, initialData);
+            host.StartWorkflow("PassingDataWorkflow", 1, new MyDataClass() { Value1 = 3, Value2 = 3 });
 
             Console.ReadLine();
             host.Stop();

src/samples/WorkflowCore.Sample03/Steps/AddNumbers.cs

@@ -7,7 +7,7 @@
 
 namespace WorkflowCore.Sample03.Steps
 {
-    public class AddNumbers : StepBody
+    public class AddNumbers : StepBodyAsync
     {
         public int Input1 { get; set; }
 
@@ -16,7 +16,7 @@ public class AddNumbers : StepBody
         public int Output { get; set; }
 
 
-        public override ExecutionResult Run(IStepExecutionContext context)
+        public override async Task<ExecutionResult> RunAsync(IStepExecutionContext context)
         {
             Output = (Input1 + Input2);
             return ExecutionResult.Next();

src/samples/WorkflowCore.Sample13/Program.cs

@@ -17,7 +17,7 @@ public static void Main(string[] args)
             host.Start();
 
             Console.WriteLine("Starting workflow...");
-            string workflowId = host.StartWorkflow("parallel-sample").Result;
+            host.StartWorkflow("parallel-sample");            
 
             Console.ReadLine();
             host.Stop();