exceptions

Author: danielgerlag

src/WorkflowCore/Exceptions/NotFoundException.cs

@@ -0,0 +1,18 @@
+using System;
+
+namespace WorkflowCore.Exceptions
+{
+    public class NotFoundException : Exception
+    {
+
+        public NotFoundException() : base()
+        {
+
+        }
+
+        public NotFoundException(string message) : base(message)
+        {
+            //
+        }
+    }
+}

src/WorkflowCore/Exceptions/WorkflowLockedException.cs

@@ -0,0 +1,12 @@
+using System;
+
+namespace WorkflowCore.Exceptions
+{
+    public class WorkflowLockedException : Exception
+    {
+        public WorkflowLockedException(): base()
+        {
+            //
+        }
+    }
+}

src/WorkflowCore/Services/ActivityController.cs

@@ -5,6 +5,7 @@
 using System.Threading;
 using System.Threading.Tasks;
 using Newtonsoft.Json;
+using WorkflowCore.Exceptions;
 using WorkflowCore.Interface;
 using WorkflowCore.Models;
 
@@ -96,11 +97,14 @@ private async Task SubmitActivityResult(string token, object result)
         {
             var tokenObj = Token.Decode(token);
             var sub = await _subscriptionRepository.GetSubscription(tokenObj.SubscriptionId);
+            if (sub == null)
+                throw new NotFoundException();
+
             if (sub.ExternalToken != token)
-                throw new InvalidOperationException("Token mismatch");
+                throw new NotFoundException("Token mismatch");
 
             if (!await _lockProvider.AcquireLock(sub.WorkflowId, CancellationToken.None))
-                throw new InvalidOperationException("Workflow is locked");
+                throw new WorkflowLockedException();
 
             try
             {

src/WorkflowCore/WorkflowCore.csproj

@@ -15,9 +15,9 @@
     <GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
     <GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
     <Description>Workflow Core is a light weight workflow engine targeting .NET Standard.</Description>
-    <Version>2.2.0</Version>
-    <AssemblyVersion>3.0.0.0</AssemblyVersion>
-    <FileVersion>3.0.0.0</FileVersion>
+    <Version>3.0.1</Version>
+    <AssemblyVersion>3.0.1.0</AssemblyVersion>
+    <FileVersion>3.0.1.0</FileVersion>
     <PackageReleaseNotes></PackageReleaseNotes>
     <PackageIconUrl>https://github.com/danielgerlag/workflow-core/raw/master/src/logo.png</PackageIconUrl>
     <PackageVersion>3.0.0</PackageVersion>

src/providers/WorkflowCore.Persistence.EntityFramework/WorkflowCore.Persistence.EntityFramework.csproj

@@ -14,7 +14,7 @@
     <GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
     <GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
     <GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
-    <Version>2.2.0</Version>
+    <Version>3.0.0</Version>
     <Description>Base package for Workflow-core peristence providers using entity framework</Description>
     <AssemblyVersion>3.0.0.0</AssemblyVersion>
     <FileVersion>3.0.0.0</FileVersion>

src/providers/WorkflowCore.Persistence.MongoDB/Services/MongoPersistenceProvider.cs

@@ -177,7 +177,7 @@ public async Task TerminateSubscription(string eventSubscriptionId)
         public async Task<EventSubscription> GetSubscription(string eventSubscriptionId)
         {
             var result = await EventSubscriptions.FindAsync(x => x.Id == eventSubscriptionId);
-            return await result.FirstAsync();
+            return await result.FirstOrDefaultAsync();
         }
 
         public async Task<EventSubscription> GetFirstOpenSubscription(string eventName, string eventKey, DateTime asOf)

src/providers/WorkflowCore.Persistence.MongoDB/WorkflowCore.Persistence.MongoDB.csproj

@@ -14,10 +14,10 @@
     <GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
     <GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
     <GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
-    <Version>2.2.0</Version>
+    <Version>3.0.1</Version>
     <Description>Provides support to persist workflows running on Workflow Core to a MongoDB database.</Description>
-    <AssemblyVersion>3.0.0.0</AssemblyVersion>
-    <FileVersion>3.0.0.0</FileVersion>
+    <AssemblyVersion>3.0.1.0</AssemblyVersion>
+    <FileVersion>3.0.1.0</FileVersion>
     <PackageVersion>3.0.0</PackageVersion>
   </PropertyGroup>
 

src/providers/WorkflowCore.Persistence.PostgreSQL/WorkflowCore.Persistence.PostgreSQL.csproj

@@ -15,7 +15,7 @@
     <GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
     <GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
     <Description>Provides support to persist workflows running on Workflow Core to a PostgreSQL database.</Description>
-    <Version>2.2.0</Version>
+    <Version>3.0.0</Version>
     <AssemblyVersion>3.0.0.0</AssemblyVersion>
     <FileVersion>3.0.0.0</FileVersion>
     <PackageVersion>3.0.0</PackageVersion>

src/providers/WorkflowCore.Persistence.SqlServer/WorkflowCore.Persistence.SqlServer.csproj

@@ -15,7 +15,7 @@
     <GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
     <GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
     <GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
-    <Version>2.2.0</Version>
+    <Version>3.0.0</Version>
     <Description>Provides support to persist workflows running on Workflow Core to a SQL Server database.</Description>
     <AssemblyVersion>3.0.0.0</AssemblyVersion>
     <FileVersion>3.0.0.0</FileVersion>

src/providers/WorkflowCore.Providers.AWS/WorkflowCore.Providers.AWS.csproj

@@ -11,7 +11,7 @@
     <PackageProjectUrl>https://github.com/danielgerlag/workflow-core</PackageProjectUrl>
     <RepositoryUrl>https://github.com/danielgerlag/workflow-core.git</RepositoryUrl>
     <RepositoryType>git</RepositoryType>
-    <Version>2.2.0</Version>
+    <Version>3.0.0</Version>
     <AssemblyVersion>3.0.0.0</AssemblyVersion>
     <PackageVersion>3.0.0</PackageVersion>
   </PropertyGroup>