Skip to content

Commit d56579a

Browse files
author
Pavlo Korobov
committed
Fix suggestions
1 parent e760e18 commit d56579a

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

src/providers/WorkflowCore.QueueProviders.RabbitMQ/ServiceCollectionExtensions.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,15 @@ public static WorkflowOptions UseRabbitMQ(this WorkflowOptions options, RabbitMq
4141
if (rabbitMqConnectionFactory == null) throw new ArgumentNullException(nameof(rabbitMqConnectionFactory));
4242

4343
options.Services.AddSingleton(rabbitMqConnectionFactory);
44-
options.Services.TryAddTransient<IRabbitMqQueueNameProvider, DefaultRabbitMqQueueNameProvider>();
44+
options.Services.TryAddSingleton<IRabbitMqQueueNameProvider, DefaultRabbitMqQueueNameProvider>();
4545
options.UseQueueProvider(RabbitMqQueueProviderFactory);
4646

4747
return options;
4848
}
4949

5050
private static IQueueProvider RabbitMqQueueProviderFactory(IServiceProvider sp)
51-
=> new RabbitMQProvider(sp);
51+
=> new RabbitMQProvider(sp,
52+
sp.GetRequiredService<IRabbitMqQueueNameProvider>(),
53+
sp.GetRequiredService<RabbitMqConnectionFactory>());
5254
}
5355
}

src/providers/WorkflowCore.QueueProviders.RabbitMQ/Services/RabbitMQProvider.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,13 @@ public class RabbitMQProvider : IQueueProvider
2626

2727
public bool IsDequeueBlocking => false;
2828

29-
public RabbitMQProvider(IServiceProvider serviceProvider)
29+
public RabbitMQProvider(IServiceProvider serviceProvider,
30+
IRabbitMqQueueNameProvider queueNameProvider,
31+
RabbitMqConnectionFactory connectionFactory)
3032
{
3133
_serviceProvider = serviceProvider;
32-
_queueNameProvider = _serviceProvider.GetRequiredService<IRabbitMqQueueNameProvider>();
33-
_rabbitMqConnectionFactory = _serviceProvider.GetRequiredService<RabbitMqConnectionFactory>();
34+
_queueNameProvider = queueNameProvider;
35+
_rabbitMqConnectionFactory = connectionFactory;
3436
}
3537

3638
public async Task QueueWork(string id, QueueType queue)

src/providers/WorkflowCore.QueueProviders.RabbitMQ/WorkflowCore.QueueProviders.RabbitMQ.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
<Description>Queue provider for Workflow-core using RabbitMQ</Description>
2020
<AssemblyVersion>2.0.0.0</AssemblyVersion>
2121
<FileVersion>2.0.0.0</FileVersion>
22+
<PackageVersion>2.1.0</PackageVersion>
2223
</PropertyGroup>
2324

2425
<ItemGroup>

0 commit comments

Comments
 (0)