remove successorids, tests

Author: danielgerlag

src/WorkflowCore/Models/ExecutionPointer.cs

@@ -42,9 +42,7 @@ public class ExecutionPointer
         public object Outcome { get; set; }
 
         public PointerStatus Status { get; set; } = PointerStatus.Legacy;
-
-        public List<string> SuccessorIds { get; set; } = new List<string>();
-
+        
         public Stack<string> Scope { get; set; } = new Stack<string>();
     }
 

src/WorkflowCore/Services/ExecutionPointerFactory.cs

@@ -25,7 +25,6 @@ public ExecutionPointer BuildStartingPointer(WorkflowDefinition def)
         public ExecutionPointer BuildNextPointer(WorkflowDefinition def, ExecutionPointer pointer, StepOutcome outcomeTarget)
         {
             var nextId = GenerateId();
-            pointer.SuccessorIds.Add(nextId);
             return new ExecutionPointer()
             {
                 Id = nextId,
@@ -62,7 +61,6 @@ public ExecutionPointer BuildChildPointer(WorkflowDefinition def, ExecutionPoint
         public ExecutionPointer BuildCompensationPointer(WorkflowDefinition def, ExecutionPointer pointer, ExecutionPointer exceptionPointer, int compensationStepId)
         {
             var nextId = GenerateId();
-            exceptionPointer.SuccessorIds.Add(nextId);
             return new ExecutionPointer()
             {
                 Id = nextId,

src/providers/WorkflowCore.Persistence.EntityFramework/ExtensionMethods.cs

@@ -61,10 +61,6 @@ internal static PersistedWorkflow ToPersistable(this WorkflowInstance instance,
                 persistedEP.Outcome = JsonConvert.SerializeObject(ep.Outcome, SerializerSettings);
                 persistedEP.Status = ep.Status;
 
-                persistedEP.SuccessorIds = string.Empty;
-                foreach (var item in ep.SuccessorIds)
-                    persistedEP.SuccessorIds += item + ";";
-
                 persistedEP.Scope = string.Empty;
                 foreach (var item in ep.Scope)
                     persistedEP.Scope += item + ";";
@@ -174,9 +170,6 @@ internal static WorkflowInstance ToWorkflowInstance(this PersistedWorkflow insta
                 pointer.Outcome = JsonConvert.DeserializeObject(ep.Outcome ?? string.Empty, SerializerSettings);
                 pointer.Status = ep.Status;
 
-                if (!string.IsNullOrEmpty(ep.SuccessorIds))
-                    pointer.SuccessorIds = ep.SuccessorIds.Split(new[] { ';' }, StringSplitOptions.RemoveEmptyEntries).ToList();
-
                 if (!string.IsNullOrEmpty(ep.Scope))
                     pointer.Scope = new Stack<string>(ep.Scope.Split(new[] { ';' }, StringSplitOptions.RemoveEmptyEntries));
 

src/providers/WorkflowCore.Persistence.EntityFramework/Models/PersistedExecutionPointer.cs

@@ -61,8 +61,6 @@ public class PersistedExecutionPointer
 
         public PointerStatus Status { get; set; } = PointerStatus.Legacy;
 
-        public string SuccessorIds { get; set; }
-
         public string Scope { get; set; }
     }
 }

src/providers/WorkflowCore.Persistence.PostgreSQL/Migrations/20171223020844_StepScope.Designer.cs

@@ -19,13 +19,7 @@ protected override void Up(MigrationBuilder migrationBuilder)
                 schema: "wfc",
                 table: "ExecutionPointer",
                 nullable: false,
-                defaultValue: 0);
-
-            migrationBuilder.AddColumn<string>(
-                name: "SuccessorIds",
-                schema: "wfc",
-                table: "ExecutionPointer",
-                nullable: true);         
+                defaultValue: 0);        
         }
 
         protected override void Down(MigrationBuilder migrationBuilder)
@@ -39,11 +33,7 @@ protected override void Down(MigrationBuilder migrationBuilder)
                 name: "Status",
                 schema: "wfc",
                 table: "ExecutionPointer");
-
-            migrationBuilder.DropColumn(
-                name: "SuccessorIds",
-                schema: "wfc",
-                table: "ExecutionPointer");            
+            
         }
     }
 }

src/providers/WorkflowCore.Persistence.PostgreSQL/Migrations/20171223020844_StepScope.cs

@@ -122,8 +122,6 @@ protected override void BuildModel(ModelBuilder modelBuilder)
                     b.Property<string>("StepName")
                         .HasMaxLength(100);
 
-                    b.Property<string>("SuccessorIds");
-
                     b.Property<long>("WorkflowId");
 
                     b.HasKey("PersistenceId");

src/providers/WorkflowCore.Persistence.PostgreSQL/Migrations/PostgresPersistenceProviderModelSnapshot.cs

@@ -19,13 +19,7 @@ protected override void Up(MigrationBuilder migrationBuilder)
                 schema: "wfc",
                 table: "ExecutionPointer",
                 nullable: false,
-                defaultValue: 0);
-
-            migrationBuilder.AddColumn<string>(
-                name: "SuccessorIds",
-                schema: "wfc",
-                table: "ExecutionPointer",
-                nullable: true);            
+                defaultValue: 0);           
         }
 
         protected override void Down(MigrationBuilder migrationBuilder)
@@ -39,11 +33,7 @@ protected override void Down(MigrationBuilder migrationBuilder)
                 name: "Status",
                 schema: "wfc",
                 table: "ExecutionPointer");
-
-            migrationBuilder.DropColumn(
-                name: "SuccessorIds",
-                schema: "wfc",
-                table: "ExecutionPointer");            
+            
         }
     }
 }

src/providers/WorkflowCore.Persistence.SqlServer/Migrations/20171223020645_StepScope.Designer.cs

@@ -125,8 +125,6 @@ protected override void BuildModel(ModelBuilder modelBuilder)
                     b.Property<string>("StepName")
                         .HasMaxLength(100);
 
-                    b.Property<string>("SuccessorIds");
-
                     b.Property<long>("WorkflowId");
 
                     b.HasKey("PersistenceId");