@@ -174,22 +174,21 @@ def test_message_equality(test_data: TestData) -> None:
174
174
175
175
176
176
@pytest .mark .parametrize ("test_data" , test_cases .messages_with_json , indirect = True )
177
- def test_message_json (repeat , test_data : TestData ) -> None :
177
+ def test_message_json (test_data : TestData ) -> None :
178
178
plugin_module , _ , json_data = test_data
179
179
180
- for _ in range (repeat ):
181
- for sample in json_data :
182
- if sample .belongs_to (test_input_config .non_symmetrical_json ):
183
- continue
180
+ for sample in json_data :
181
+ if sample .belongs_to (test_input_config .non_symmetrical_json ):
182
+ continue
184
183
185
- message : betterproto .Message = plugin_module .Test ()
184
+ message : betterproto .Message = plugin_module .Test ()
186
185
187
- message .from_json (sample .json )
188
- message_json = message .to_json (0 )
186
+ message .from_json (sample .json )
187
+ message_json = message .to_json (0 )
189
188
190
- assert dict_replace_nans (json .loads (message_json )) == dict_replace_nans (
191
- json .loads (sample .json )
192
- )
189
+ assert dict_replace_nans (json .loads (message_json )) == dict_replace_nans (
190
+ json .loads (sample .json )
191
+ )
193
192
194
193
195
194
@pytest .mark .parametrize ("test_data" , test_cases .services , indirect = True )
@@ -198,28 +197,27 @@ def test_service_can_be_instantiated(test_data: TestData) -> None:
198
197
199
198
200
199
@pytest .mark .parametrize ("test_data" , test_cases .messages_with_json , indirect = True )
201
- def test_binary_compatibility (repeat , test_data : TestData ) -> None :
200
+ def test_binary_compatibility (test_data : TestData ) -> None :
202
201
plugin_module , reference_module , json_data = test_data
203
202
204
203
for sample in json_data :
205
204
reference_instance = Parse (sample .json , reference_module ().Test ())
206
205
reference_binary_output = reference_instance .SerializeToString ()
207
206
208
- for _ in range (repeat ):
209
- plugin_instance_from_json : betterproto .Message = (
210
- plugin_module .Test ().from_json (sample .json )
211
- )
212
- plugin_instance_from_binary = plugin_module .Test .FromString (
213
- reference_binary_output
214
- )
215
-
216
- # Generally this can't be relied on, but here we are aiming to match the
217
- # existing Python implementation and aren't doing anything tricky.
218
- # https://developers.google.com/protocol-buffers/docs/encoding#implications
219
- assert bytes (plugin_instance_from_json ) == reference_binary_output
220
- assert bytes (plugin_instance_from_binary ) == reference_binary_output
221
-
222
- assert plugin_instance_from_json == plugin_instance_from_binary
223
- assert dict_replace_nans (
224
- plugin_instance_from_json .to_dict ()
225
- ) == dict_replace_nans (plugin_instance_from_binary .to_dict ())
207
+ plugin_instance_from_json : betterproto .Message = plugin_module .Test ().from_json (
208
+ sample .json
209
+ )
210
+ plugin_instance_from_binary = plugin_module .Test .FromString (
211
+ reference_binary_output
212
+ )
213
+
214
+ # Generally this can't be relied on, but here we are aiming to match the
215
+ # existing Python implementation and aren't doing anything tricky.
216
+ # https://developers.google.com/protocol-buffers/docs/encoding#implications
217
+ assert bytes (plugin_instance_from_json ) == reference_binary_output
218
+ assert bytes (plugin_instance_from_binary ) == reference_binary_output
219
+
220
+ assert plugin_instance_from_json == plugin_instance_from_binary
221
+ assert dict_replace_nans (
222
+ plugin_instance_from_json .to_dict ()
223
+ ) == dict_replace_nans (plugin_instance_from_binary .to_dict ())
0 commit comments