core: Put Character::BinaryData's field behind a Gc

Author: moulins

core/src/avm2/object/bytearray_object.rs

@@ -6,6 +6,7 @@ use crate::avm2::value::Value;
 use crate::avm2::Error;
 use crate::avm2::Multiname;
 use crate::character::Character;
+use crate::tag_utils::SwfSlice;
 use crate::utils::HasPrefixField;
 use core::fmt;
 use gc_arena::{Collect, Gc, GcWeak};
@@ -24,7 +25,9 @@ pub fn byte_array_allocator<'gc>(
     {
         if let Some(lib) = activation.context.library.library_for_movie(movie) {
             if let Some(Character::BinaryData(binary_data)) = lib.character_by_id(id) {
-                Some(ByteArrayStorage::from_vec(binary_data.as_ref().to_vec()))
+                Some(ByteArrayStorage::from_vec(
+                    SwfSlice::as_ref(binary_data).to_vec(),
+                ))
             } else {
                 None
             }

core/src/character.rs

@@ -6,7 +6,7 @@ use crate::display_object::{
     Avm1Button, Avm2Button, BitmapClass, EditText, Graphic, MorphShape, MovieClip, Text, Video,
 };
 use crate::font::Font;
-use gc_arena::{Collect, GcCell};
+use gc_arena::{Collect, Gc, GcCell};
 use ruffle_render::bitmap::{BitmapHandle, BitmapSize};
 use swf::DefineBitsLossless;
 
@@ -33,7 +33,7 @@ pub enum Character<'gc> {
     Text(Text<'gc>),
     Sound(#[collect(require_static)] SoundHandle),
     Video(Video<'gc>),
-    BinaryData(BinaryData),
+    BinaryData(Gc<'gc, BinaryData>),
 }
 
 /// Holds a bitmap from an SWF tag, plus the decoded width/height.

core/src/display_object/movie_clip.rs

@@ -3678,6 +3678,7 @@ impl<'gc, 'a> MovieClipShared<'gc> {
     ) -> Result<(), Error> {
         let tag_data = reader.read_define_binary_data()?;
         let binary_data = BinaryData::from_swf_tag(self.movie(), &tag_data);
+        let binary_data = Gc::new(context.gc(), binary_data);
         self.library_mut(context)
             .register_character(tag_data.id, Character::BinaryData(binary_data));
         Ok(())