Skip to content

Commit e5964ed

Browse files
committed
avm2: Throw error when setting TextFormat.display to null
Flash Player throws ruffle-rs#2007 in this case.
1 parent cc53017 commit e5964ed

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

core/src/avm2/globals/flash/text/text_format.rs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use crate::avm2::activation::Activation;
2-
use crate::avm2::error::make_error_2008;
2+
use crate::avm2::error::{make_error_2007, make_error_2008};
33
use crate::avm2::object::ArrayObject;
44
use crate::avm2::parameters::ParametersExt;
55
use crate::avm2::value::Value;
@@ -243,10 +243,7 @@ pub fn set_display<'gc>(
243243
let value = args.get_value(0);
244244
let value = match value {
245245
Value::Undefined => unreachable!("Object parameter is never Undefined"),
246-
Value::Null => {
247-
text_format.display = None;
248-
return Ok(Value::Undefined);
249-
}
246+
Value::Null => return Err(make_error_2007(activation, "display")),
250247
value => value.coerce_to_string(activation)?,
251248
};
252249

0 commit comments

Comments
 (0)