pixelbender: Implement boolean parameters

Implementation is based mostly on tests and assumes that boolean
parameters behave similarly to int parameters.

Author: kjarosh

core/src/pixel_bender.rs

@@ -180,6 +180,21 @@ impl PixelBenderTypeExt for PixelBenderType {
             PixelBenderType::TInt4(i1, i2, i3, i4) => {
                 vec![(*i1).into(), (*i2).into(), (*i3).into(), (*i4).into()]
             }
+            PixelBenderType::TBool(b) => vec![(*b as i16).into()],
+            PixelBenderType::TBool2(b1, b2) => vec![(*b1 as i16).into(), (*b2 as i16).into()],
+            PixelBenderType::TBool3(b1, b2, b3) => vec![
+                (*b1 as i16).into(),
+                (*b2 as i16).into(),
+                (*b3 as i16).into(),
+            ],
+            PixelBenderType::TBool4(b1, b2, b3, b4) => {
+                vec![
+                    (*b1 as i16).into(),
+                    (*b2 as i16).into(),
+                    (*b3 as i16).into(),
+                    (*b4 as i16).into(),
+                ]
+            }
         };
         let storage = ArrayStorage::from_args(&vals);
         Ok(ArrayObject::from_storage(activation, storage).into())

render/naga-pixelbender/src/lib.rs

@@ -487,7 +487,11 @@ impl ShaderBuilder<'_> {
                             num_vec4fs += 1;
                             (float_offset, ParamKind::Float)
                         }
-                        PixelBenderTypeOpcode::TInt
+                        PixelBenderTypeOpcode::TBool
+                        | PixelBenderTypeOpcode::TBool2
+                        | PixelBenderTypeOpcode::TBool3
+                        | PixelBenderTypeOpcode::TBool4
+                        | PixelBenderTypeOpcode::TInt
                         | PixelBenderTypeOpcode::TInt2
                         | PixelBenderTypeOpcode::TInt3
                         | PixelBenderTypeOpcode::TInt4 => {

render/src/pixel_bender.rs

@@ -47,6 +47,10 @@ pub enum PixelBenderType {
     TInt3(i16, i16, i16) = 0xA,
     TInt4(i16, i16, i16, i16) = 0xB,
     TString(String) = 0xC,
+    TBool(bool) = 0xD,
+    TBool2(bool, bool) = 0xE,
+    TBool3(bool, bool, bool) = 0xF,
+    TBool4(bool, bool, bool, bool) = 0x10,
 }
 
 // FIXME - come up with a way to reduce duplication here
@@ -64,6 +68,10 @@ pub enum PixelBenderTypeOpcode {
     TInt3 = 0xA,
     TInt4 = 0xB,
     TString = 0xC,
+    TBool = 0xD,
+    TBool2 = 0xE,
+    TBool3 = 0xF,
+    TBool4 = 0x10,
 }
 
 #[derive(Debug, PartialEq, Copy, Clone)]
@@ -140,6 +148,10 @@ impl Display for PixelBenderTypeOpcode {
                 PixelBenderTypeOpcode::TInt3 => "int3",
                 PixelBenderTypeOpcode::TInt4 => "int4",
                 PixelBenderTypeOpcode::TString => "string",
+                PixelBenderTypeOpcode::TBool => "bool",
+                PixelBenderTypeOpcode::TBool2 => "bool2",
+                PixelBenderTypeOpcode::TBool3 => "bool3",
+                PixelBenderTypeOpcode::TBool4 => "bool4",
             }
         )
     }
@@ -726,6 +738,24 @@ fn read_value<R: Read>(
             data.read_i16::<LittleEndian>()?,
         )),
         PixelBenderTypeOpcode::TString => Ok(PixelBenderType::TString(read_string(data)?)),
+        PixelBenderTypeOpcode::TBool => Ok(PixelBenderType::TBool(
+            data.read_i16::<LittleEndian>()? != 0,
+        )),
+        PixelBenderTypeOpcode::TBool2 => Ok(PixelBenderType::TBool2(
+            data.read_i16::<LittleEndian>()? != 0,
+            data.read_i16::<LittleEndian>()? != 0,
+        )),
+        PixelBenderTypeOpcode::TBool3 => Ok(PixelBenderType::TBool3(
+            data.read_i16::<LittleEndian>()? != 0,
+            data.read_i16::<LittleEndian>()? != 0,
+            data.read_i16::<LittleEndian>()? != 0,
+        )),
+        PixelBenderTypeOpcode::TBool4 => Ok(PixelBenderType::TBool4(
+            data.read_i16::<LittleEndian>()? != 0,
+            data.read_i16::<LittleEndian>()? != 0,
+            data.read_i16::<LittleEndian>()? != 0,
+            data.read_i16::<LittleEndian>()? != 0,
+        )),
     }
 }
 

render/wgpu/src/pixel_bender.rs

@@ -588,6 +588,16 @@ pub(super) fn run_pixelbender_shader_impl(
                         FloatOrInt::Float(vec4_arr)
                     }
                     PixelBenderType::TFloat4x4(arr) => FloatOrInt::Float(arr.to_vec()),
+                    PixelBenderType::TBool(b1) => FloatOrInt::Int(vec![*b1 as i32, 0, 0, 0]),
+                    PixelBenderType::TBool2(b1, b2) => {
+                        FloatOrInt::Int(vec![*b1 as i32, *b2 as i32, 0, 0])
+                    }
+                    PixelBenderType::TBool3(b1, b2, b3) => {
+                        FloatOrInt::Int(vec![*b1 as i32, *b2 as i32, *b3 as i32, 0])
+                    }
+                    PixelBenderType::TBool4(b1, b2, b3, b4) => {
+                        FloatOrInt::Int(vec![*b1 as i32, *b2 as i32, *b3 as i32, *b4 as i32])
+                    }
                     _ => unreachable!("Unimplemented value {value:?}"),
                 };