better global vars duplication prevention

Author: danielhrisca

src/asammdf/gui/widgets/file.py

@@ -1278,23 +1278,11 @@ def load_channel_list(self, event=None, file_name=None, manually=False, show_pro
             self.loaded_display_file = file_name, worker.hexdigest()
 
         else:
-            extension = None
+            extension = ".dict"
             info = file_name
             channels = info.get("selected_channels", [])
             self.loaded_display_file = Path(info.get("display_file_name", "")), b""
 
-            self.functions.update(info.get("functions", {}))
-            global_vars = [
-                line.strip()
-                for line in self.global_variables.splitlines()
-                if line.strip()
-            ]
-            for line in info.get('global_variables', '').splitlines():
-                line = line.strip()
-                if line and line not in global_vars:
-                    global_vars.append(line)
-            self.global_variables = "\n".join(global_vars)
-
         if channels:
             iterator = QtWidgets.QTreeWidgetItemIterator(self.channels_tree)
 
@@ -1325,7 +1313,16 @@ def load_channel_list(self, event=None, file_name=None, manually=False, show_pro
 
         self.clear_windows()
 
-        if extension in (".dspf", ".dsp"):
+        if extension in (".dspf", ".dsp", ".dict"):
+            new_global_vars = "\n".join(line.strip() for line in info.get('global_variables', '').splitlines() if line.strip())
+            global_vars = "\n".join(line.strip() for line in self.global_variables.splitlines() if line.strip())
+
+            if new_global_vars not in global_vars:
+                global_vars += new_global_vars
+                updated_global_vars = True
+            else:
+                updated_global_vars = False
+
             new_functions = {}
 
             if "functions" in info:
@@ -1358,8 +1355,8 @@ def load_channel_list(self, event=None, file_name=None, manually=False, show_pro
                                     "definition": definition,
                                 }
 
-            if new_functions or info.get("global_variables", "") != self.global_variables:
-                self.update_functions({}, new_functions, f"{self.global_variables}\n{info.get('global_variables', '')}")
+            if new_functions or updated_global_vars:
+                self.update_functions({}, new_functions, global_vars)
 
         windows = info.get("windows", [])
         errors = {}

src/asammdf/gui/widgets/mdi_area.py

@@ -3424,7 +3424,7 @@ def edit_channel(self, channel, item, widget):
                 if old_name in required_channels:
                     item = widget.item_by_uuid
 
-                    computed_channel = widget.plot.channel_item_to_config(item)
+                    computed_channel = widget.channel_item_to_config(item)
                     computed_channel["computation"] = replace_computation_dependency(
                         computed_channel["computation"], old_name, new_name
                     )