Curr-games Discussions

[danielmason89]

Hi @LucasWinkler
Let's discuss all of the curr-game things here 🙂

[LucasWinkler]

@danielmason89 you're free to create a branch to implement the UI now.

I'm was having a hard time with the schema. It's pretty rough trying to fully validate a 3rd party API. There's a lot of fields that might not be returned in the response. For now I think the schema is correct enough. There might be issues with specific games but we won't really know until we get a game with an unexpected response object.

I added some comments as well. There are example components and pages for getting all games (unfiltered), the original categories on the home page from the old site, a search bar, individual game details etc... You can remove all of these when migrating the old code.

[LucasWinkler]

• actions: RTK query handles this so we can remove this
• hooks: We don't need the old redux hooks that are inside of it as these have been replaced
• img: Can move the contents to either src/client/assets or src/public (optionally can add a /images folder inside these)
• reducers: RTK query handles this so we can remove this
• types: You can remove this as we have shared types in /src/shared, and types in both client and server (we dont have any server types at this time)
• animations.ts: I'm not sure how the animations will work in the latest version. We may need to keep this file. Should probably move it into the utils folder
• api: Remove this

That should be good let me know! @danielmason89

[danielmason89]

Awesome, thank you @LucasWinkler that was a huge help. I think we should get together at some point before the weekend to go dicuss the Nav, the components and their related functionality, as well as the pages portion of the migration.

What are you free?

[LucasWinkler]

@danielmason89 I'm a little busy today how about tomorrow? I should be available whenever you are. If not tomorrow just choose another day and I should be able to make it as I don't do a whole lot.

[danielmason89]

@LucasWinkler Yea, it's no rush at all. Tomorrow's works for me, what time did you have in mind?

[LucasWinkler]

@danielmason89 I'm available all day. I'm not sure when you're available but if you're able to have a meeting around the same time as normal (2ish) then that would be great. If not we could do it later as well (4 or 5?) or even earlier it just depends on your schedule.

[danielmason89]

I managed to migrate most of the things over though want to discuss some of the components with you to better understand how things are functioning with the updated Redux Toolkit, and associated backend.

Moreover, to figure out the pages aspect of things, and start thinking about how to rap up the migration/update stage of the project, and focus on adding new features going forward.

[danielmason89]

Great! What time works best for you?

[LucasWinkler]

I think you missed my last message but right above has these times (#61 (reply in thread))

What do you think?

[danielmason89]

Oh sorry, that my bad. I didn't see it.
4 pm works for me, is that still good for you?

[LucasWinkler]

@danielmason89 yeah works great for me!

[danielmason89]

cool! I just sent you an ivite to a google meeting instance, here's the link though if you didn't receive the email, https://meet.google.com/cic-kxce-yjh

[danielmason89]

Hi @LucasWinkler , there's been some updates to the main branch, be sure to update your version of the main branch and/or the branch your working on.

Cheers, and talk to you this weekend 😊

[LucasWinkler]

Sounds good! I actually might be busy this weekend. I'll definitely be busy on Saturday but can maybe find time Sunday unless you wanted to check in earlier.

[danielmason89]

Thank you! Alright, same. Do you want to sync up Sunday afternoon then around 11:30 am? Or would earier in the day be better for you on Sunday?

Cheers,
Daniel

[LucasWinkler]

11:30 am Sunday sounds good to me.

[danielmason89]

Awesome! talk to you then 😊

[danielmason89]

I've updated the time and date for our meeting this weekend

[danielmason89]

Hi @LucasWinkler, can we can our meeup for today?
I'm still working on the assignment due tomorrow for the backend class.

[LucasWinkler]

@danielmason89 I've made 2 PRs, try to merge the SEO pr (#115) before the UI improvements pr (#116)! Thanks

[danielmason89]

@LucasWinkler Amazing, thank you @LucasWinkler. I'll approve them now.