antialiasing and window plotting (no_window) functions added

Author: danielparthier

ephys/classes/plot/plot_params.py

@@ -32,7 +32,7 @@ class PlotParams:
         show (bool): Whether to show the plot.
         return_fig (bool): Whether to return the figure object.
         window_mode (str): Mode for handling windows
-            ('use_plot', 'use_trace', 'add_to_trace').
+            ('use_plot', 'use_trace', 'add_to_trace', 'no_window').
         theme (str): Theme for the plot ('dark' or 'light').
     """
 
@@ -60,10 +60,12 @@ def __init__(
         self.xlim = kwargs.get("xlim", (0, 0))
         self.show = kwargs.get("show", True)
         self.return_fig = kwargs.get("return_fig", False)
+        self.plot_window = kwargs.get("plot_window", True)
         self.window_mode = kwargs.get(
             "window_mode", "add_to_trace"
         )  # Default mode for handling windows
         self.line_width = kwargs.get("line_width", 1.0)
+        self.antialiasing = kwargs.get("antialiasing", True)
 
     def apply_theme(self, theme="dark") -> None:
         """Apply the specified theme to the plot parameters.
@@ -120,10 +122,17 @@ def validate(self) -> None:
             raise TypeError("show must be a boolean value.")
         if not isinstance(self.return_fig, bool):
             raise TypeError("return_fig must be a boolean value.")
-        if self.window_mode not in ["use_plot", "use_trace", "add_to_trace"]:
+        if not isinstance(self.plot_window, bool):
+            raise TypeError("plot_window must be a boolean value.")
+        if self.window_mode not in [
+            "use_plot",
+            "use_trace",
+            "add_to_trace",
+            "no_window",
+        ]:
             raise ValueError(
                 f"Invalid window_mode: {self.window_mode}. "
-                "Must be 'use_plot', 'use_trace', or 'add_to_trace'."
+                "Must be 'use_plot', 'use_trace', 'add_to_trace', or 'no_window'."
             )
         if not isinstance(self.align_onset, bool):
             raise TypeError("align_onset must be a boolean value.")
@@ -135,6 +144,8 @@ def validate(self) -> None:
             raise TypeError("line_width must be a number (int or float).")
         if not isinstance(self.theme, str) and self.theme not in ["dark", "light"]:
             raise TypeError("theme must be a string and either 'dark' or 'light'.")
+        if not isinstance(self.antialiasing, bool):
+            raise TypeError("antialiasing must be a boolean value.")
 
     def to_dict(self) -> dict:
         """Convert the plot parameters to a dictionary."""
@@ -153,12 +164,14 @@ def to_dict(self) -> dict:
             "bg_color": self.bg_color,
             "axis_color": self.axis_color,
             "window": self.window,
+            "plot_window": self.plot_window,
             "window_color": self.window_color,
             "xlim": self.xlim,
             "show": self.show,
             "return_fig": self.return_fig,
             "window_mode": self.window_mode,
             "theme": self.theme,
+            "antialiasing": self.antialiasing,
         }
 
     def __iter__(self):

ephys/classes/plot/plot_trace.py

@@ -22,10 +22,6 @@
 from ephys.classes.plot.plot_params import PlotParams, _set_axs_color
 
 
-# switch off antialiasing for pyqtgraph
-# pg.setConfigOptions(antialias=False)
-
-
 class TracePlot:
     """Base class for plotting traces."""
 
@@ -84,7 +80,11 @@ def handle_windows(self) -> list:
             else:
                 windows_to_display = self.trace.window
 
-        # Case 3: Use windows from plot without modifying trace.window
+        # Case 3: No windows to display
+        elif self.params.window_mode == "no_window":
+            windows_to_display = []
+
+        # Case 4: Use windows from plot without modifying trace.window
         else:  # self.params.window_mode == "use_plot"
             if isinstance(self.params.window, tuple):
                 windows_to_display = [self.params.window]
@@ -308,6 +308,8 @@ def plot(
         if kwargs:
             self.params.update_params(**kwargs)
 
+        pg.setConfigOptions(antialias=self.params.antialiasing)
+
         def sync_channels(source_region, channel_items, window_index=0):
             # Get region bounds from the source region
             min_val, max_val = source_region.getRegion()
@@ -481,7 +483,7 @@ def make_region_callback(region_obj, channel_items, window_index=0):
                     time_array[0, :],
                     channel.average.trace,
                     skipFiniteCheck=True,
-                    antialias=False,
+                    antialias=self.params.antialiasing,
                 )
                 channel_tmp.addItem(average_sweep)
 
@@ -529,7 +531,7 @@ def update_theme(self, theme: str, **kwargs) -> None:
                 self._set_curve_pen(plot_item.listDataItems())
 
     def sweep_highlight(
-        self, sweep_index: int | None = None, color="red", alpha=1, width=2
+        self, sweep_index: int | None = None, color="red", alpha=1, width=1
     ) -> None:
         """
         Highlights a specific sweep in the plot by adjusting the pen properties of the curves.
@@ -562,12 +564,7 @@ def sweep_highlight(
         for plot_item in plot_items:
             for sweep in plot_item.listDataItems():
                 if isinstance(sweep, HighlightCurve):
-                    sweep.update_data(
-                        sweep_index=sweep_index,
-                    )
-                    sweep.setPen(
-                        pen=pen_opts,
-                    )
+                    sweep.update_data(sweep_index=sweep_index, pen=pen_opts)
                     highlight_exists = sweep.sweep_index is not None
 
         if not highlight_exists and isinstance(sweep_index, int):