some self-review

Author: maxstevens-nl

package.json

@@ -40,7 +40,6 @@
   "devDependencies": {
     "@antfu/eslint-config": "latest",
     "@rocicorp/resolver": "1.0.2",
-    "@testing-library/vue": "^8.1.0",
     "@vitest/coverage-v8": "latest",
     "bumpp": "latest",
     "changelogithub": "13.16.0",

src/create-zero.ts

@@ -5,7 +5,7 @@ import { shallowRef, toValue, watch } from 'vue'
 
 export const zeroSymbol = Symbol('zero') as InjectionKey<ShallowRef<Zero<Schema, undefined>>>
 
-const oldZeroCleanups = new Set()
+const zeroCleanups = new Set()
 
 export function createZero<S extends Schema = Schema, MD extends CustomMutatorDefs | undefined = undefined>(optsOrZero: MaybeRefOrGetter<ZeroOptions<S, MD> | { zero: Zero<S, MD> }>) {
   const z = shallowRef() as ShallowRef<Zero<S, MD>>
@@ -15,17 +15,17 @@ export function createZero<S extends Schema = Schema, MD extends CustomMutatorDe
 
   watch(() => toValue(optsOrZero), (opts) => {
     const cleanupZeroPromise = z.value.close()
-    oldZeroCleanups.add(cleanupZeroPromise)
+    zeroCleanups.add(cleanupZeroPromise)
     cleanupZeroPromise.finally(() => {
-      oldZeroCleanups.delete(cleanupZeroPromise)
+      zeroCleanups.delete(cleanupZeroPromise)
     })
 
     z.value = 'zero' in opts ? opts.zero : new Zero(opts)
   }, { deep: true })
 
   return {
     install: (app: App) => {
-      // @ts-expect-error - TODO: type properly
+      // @ts-expect-error - The type of z doesn't line up with the type of zeroSymbol.
       app.provide(zeroSymbol, z)
     },
   }