qa_fixedlen_to_pdu freezes under GNU Radio 3.10.1.1

[DL7NDR]

[ 10%] Building CXX object lib/CMakeFiles/gnuradio-satellites.dir/fixedlen_to_pdu_impl.cc.o
In file included from /home/user/gr-satellites-main/lib/fixedlen_to_pdu_impl.cc:11:
/home/user/gr-satellites-main/lib/fixedlen_to_pdu_impl.h:34:16: error: ‘optional’ in namespace ‘std’ does not name a template type
34 | const std::optionalpmt::pmt_t d_packet_length_tag;
| ^~~~~~~~
/home/user/gr-satellites-main/lib/fixedlen_to_pdu_impl.h:34:11: note: ‘std::optional’ is only available from C++17 onwards
34 | const std::optionalpmt::pmt_t d_packet_length_tag;
| ^~~
/home/user/gr-satellites-main/lib/fixedlen_to_pdu_impl.cc: In constructor ‘gr::satellites::fixedlen_to_pdu_impl::fixedlen_to_pdu_impl(gr::types::vector_type, const string&, size_t, bool, const string&)’:
/home/user/gr-satellites-main/lib/fixedlen_to_pdu_impl.cc:42:7: error: class ‘gr::satellites::fixedlen_to_pdu_impl’ does not have any field named ‘d_packet_length_tag’
42 | d_packet_length_tag(packet_length_tag_key.empty()
| ^~~~~~~~~~~~~~~~~~~
/home/user/gr-satellites-main/lib/fixedlen_to_pdu_impl.cc:43:38: error: ‘nullopt’ is not a member of ‘std’
43 | ? std::nullopt
| ^~~~~~~
/home/user/gr-satellites-main/lib/fixedlen_to_pdu_impl.cc:44:38: error: ‘optional’ is not a member of ‘std’
44 | : std::optional(pmt::mp(packet_length_tag_key))),
| ^~~~~~~~
/home/user/gr-satellites-main/lib/fixedlen_to_pdu_impl.cc:44:38: note: ‘std::optional’ is only available from C++17 onwards
/home/user/gr-satellites-main/lib/fixedlen_to_pdu_impl.cc: In member function ‘virtual int gr::satellites::fixedlen_to_pdu_impl::work(int, gr_vector_const_void_star&, gr_vector_void_star&)’:
/home/user/gr-satellites-main/lib/fixedlen_to_pdu_impl.cc:71:13: error: ‘d_packet_length_tag’ was not declared in this scope
71 | if (d_packet_length_tag.has_value()) {
| ^~~~~~~~~~~~~~~~~~~
make[2]: *** [lib/CMakeFiles/gnuradio-satellites.dir/build.make:244: lib/CMakeFiles/gnuradio-satellites.dir/fixedlen_to_pdu_impl.cc.o] error 1
make[1]: *** [CMakeFiles/Makefile2:682: lib/CMakeFiles/gnuradio-satellites.dir/all] error 2
make: *** [Makefile:146: all] error 2

On Lubuntu Kernel 6.2.0

[daniestevez]

‘std::optional’ is only available from C++17 onwards

It looks like you might be using a compiler which is too old. Can you give more details about your system, including gcc version?

[DL7NDR]

gcc 4:11.2.0-1ubuntu1

Can you give more details about your system
Of course. Which details do you need?

[daniestevez]

I think I've found the issue. The CMakeLists.txt is specifying C++14, but gr-satellites is now using C++17 features. This is because the C++ standard in the CMakeLists.txt hasn't been changed in many years. Apparently the gcc-11 that you have is one of the few compilers that complains about this, since I hadn't seen this problem before. gcc-11 supports C++17, but it looks like it insists in building in C++14 mode. I've just merged #777 to main, which fixes this. Let me know if you still have the problem with the latest main.

[DL7NDR]

Thank you, make runs now smoothly.

However make test freezes at qa_fixedlen_tagger.

Running tests...
Test project /home/o30/gr-satellites-main/build
Start 1: qa_costas_loop_8apsk_cc
1/30 Test #1: qa_costas_loop_8apsk_cc .......... Passed 1.01 sec
Start 2: qa_crc
2/30 Test #2: qa_crc ........................... Passed 0.94 sec
Start 3: qa_fixedlen_tagger

[daniestevez]

I have realized that there are two unit tests that are called qa_fixedlen_tagger (one of them incorrectly). So I am not sure of which of the two is getting stuck in your case. I have fixed this problem in #778. Could you try again with the latest main?

[DL7NDR]

still freezing.

[daniestevez]

That is expected. The question is whether it freezes in a test called qa_fixedlen_tagger or in a test called qa_fixedlen_to_pdu. The two tests had the same name before.

[DL7NDR]

qa_fixedlen_tagger

[daniestevez]

That is good news. The fixedlen_tagger block that this test is testing has been deprecated for almost 3 years now, so this is a good chance to remove it. I don't know why this test is failing for you, but I have just removed the block and its test in #779. You should try again with the latest main.

[DL7NDR]

It's now freezing at qa_fixedlen_to_pdu

[daniestevez]

First, try running only this test by doing ctest -V -R qa_fixedlen_to_pdu and paste here the full output (properly formatted using markdown) just in case that gives any clues about what is the problem.

Second, give more details about your system, including GNU Radio version, how GNU Radio was installed, etc. Any piece of information could be useful to solve the problem, so please include as much information as you can.

Keep in mind that this problem doesn't happen in CI or in any of the machines I've recently tested gr-satellites, so unless you give a way in which the problem can be reproduced (maybe by replicating your system in a Docker container) or you give very detailed information, it will be impossible to help solve this.

[DL7NDR]

UpdateCTestConfiguration from :/home/user/gr-satellites-main/build/DartConfiguration.tcl
UpdateCTestConfiguration from :/home/user/gr-satellites-main/build/DartConfiguration.tcl
Test project /home/user/gr-satellites-main/build
Constructing a list of tests
Done constructing a list of tests
Updating test list for fixtures
Added 0 tests to meet fixture requirements
Checking test dependency graph...
Checking test dependency graph end
test 3
Start 3: qa_fixedlen_to_pdu

3: Test command: /usr/bin/sh "qa_fixedlen_to_pdu_test.sh"
3: Test timeout computed to be: 10000000
3: /usr/lib/python3/dist-packages/gnuradio/gr/top_block.py:48: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead
3: self.setDaemon(1)

--
gnuradio 3.10.1.1, installed with sudo apt install gnuradio

cmake-output.txt