Adding email addresses does not work for django-allauth-ui v. 1.1.6 under django-allauth v. 0.63.4

[Naggafin]

I have the beginnings of a project utilizing django-allauth and django-allauth-ui setup. I have made no modifications to either django-allauth or django-allauth-ui, nor overridden any templates or project files. They're both stock and as-is. When launching my project to test out basic account functionality, I noticed that nothing happens when I log in as a user and go to add an email address for the first time. I set a breakpoint in the allauth email management view to discover the cause, and it appears to be right here:

# allauth.account.views

...

class EmailView(AjaxCapableProcessFormViewMixin, FormView):
    ...

    def post(self, request, *args, **kwargs):
        res = None
        if "action_add" in request.POST:  # <- problem is here: 'action_add' is not in the POST data
            res = super(EmailView, self).post(request, *args, **kwargs)
        elif request.POST.get("email"):  # <- so it goes to this
            if "action_send" in request.POST:
                res = self._action_send(request)
            elif "action_remove" in request.POST:
                res = self._action_remove(request)
            elif "action_primary" in request.POST:
                res = self._action_primary(request)
            res = res or HttpResponseRedirect(self.get_success_url())  # <- but none of the checks above pass, so this line is executed w/ res being a redirect
            # Given that we bypassed AjaxCapableProcessFormViewMixin,
            # we'll have to call invoke it manually...
            res = _ajax_response(request, res, data=self._get_ajax_data_if())
        else:
            # No email address selected
            res = HttpResponseRedirect(self.success_url)
            res = _ajax_response(request, res, data=self._get_ajax_data_if())
        return res

...

It appears, when submitting the form to add a new email address, that a required POST field is missing. and it reverts to the default behavior of redirecting to the success url. I would suspect that this behavior is not intended, as the way it stands currently is that it is impossible to add new email addresses. I believe a hidden form field is missing which adds the key being checked for to the POST data.

[danihodovic]

Do you want to take a stab at this? You can compare the templates between allauth and allauth_ui and deduce from there.

I'm guessing the problematic code is here:

• django-allauth-ui/allauth_ui/templates/account/email.html

  Lines 46 to 53 in 3df6ee1

  	{% if can_add_email %}
  	<div class="divider"></div>
  	<h2 class="py-3 text-lg">{% trans "Add Email Address" %}</h2>
  	{% trans "Add Email" as button_text %}
  	{% #form form=form url=url button_text=button_text %}
  	{% csrf_token %}
  	{% /form %}
  	{% endif %}

• https://github.com/pennersr/django-allauth/blob/main/allauth/templates/account/email.html#L57-L74

[Naggafin]

I can look into it. Busy schedule but simple enough fix. I'll submit a PR tomorrow.

[Naggafin]

Oops. Didn't mean to close this

[lilerjee]

allauth needs this field "action_add" which will be sent to server with empty value. So need to add the name to submit button (change the template tile account/email.html):

        {% #form form=form url=action_url button_text=button_text use_default_button="false" %}
        {% csrf_token %}
          <button type="submit" name="action_add" class="my-3 btn">{{ button_text }}</button>
        {% /form %}

[danihodovic]

@lilerjee do you want to open a pull-request?

[danihodovic]

Seems fixed thanks to @lilerjee and #123