Merge pull request #3 from danilo04/fix-get-car-items

Retornar 404 cuando el carrito de compras no existe

Author: danilo04

routes/cart.js

@@ -27,7 +27,12 @@ router.post('/:cartId/items', async (req, res) => {
 router.get('/:cartId/items', async (req, res) => {
   try {
     const items = await CartService.getCartItems(req.params.cartId);
-    res.json(items);
+    if (items) {
+      res.json(items);
+    } else {
+      res.status(404).json({ error: "Cart doesn't exist" });
+    }
+    
   } catch (error) {
     res.status(400).json({ error: error.message });
   }

services/cartService.js

@@ -36,6 +36,15 @@ class CartService {
   }
 
   static async getCartItems(cartId) {
+    if (isNaN(cartId)) {
+      throw new Error('Cart ID should be a number');
+    }
+
+    const cart = await Cart.findByPk(cartId)
+    if (!cart) {
+      return null;
+    }
+
     const items = await CartItem.findAll({
       where: { cartId },
       include: Product,

tests/routes/cart.test.js

@@ -53,8 +53,16 @@ describe('Cart Routes', () => {
   });
 
   describe('GET /api/carts/:cartId/items', () => {
-    it('should return cart items with totals', async () => {
+    it('should return 404 when cart does not exist', async () => {
+      const response = await request(app)
+      .get('/api/carts/1/items')
+      .expect(404);
+    });
 
+    it('should return 400 when cart id wrong format', async () => {
+      const response = await request(app)
+      .get('/api/carts/nonidad123/items')
+      .expect(400);
     });
   });
 });