Skip to content

Commit 7a082ce

Browse files
committed
fix(dependencies): move native dependencies to native module
1 parent 832edd7 commit 7a082ce

File tree

3 files changed

+20
-9
lines changed

3 files changed

+20
-9
lines changed

package.json

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,7 @@
4747
"lint": "eslint --ext .jsx --ext .ts,.tsx src/",
4848
"release": "semantic-release"
4949
},
50-
"dependencies": {
51-
"react-native-svg": "9.6.4"
52-
},
50+
"dependencies": {},
5351
"devDependencies": {
5452
"@babel/core": "7.5.5",
5553
"@babel/polyfill": "7.4.4",
@@ -100,8 +98,7 @@
10098
"typescript": "3.5.3"
10199
},
102100
"peerDependencies": {
103-
"react": "^16.0.0",
104-
"react-native": "^0.60.5"
101+
"react": "^16.0.0"
105102
},
106103
"husky": {
107104
"hooks": {

src/__tests__/dependency.test.tsx

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,15 @@
11
import pkg from '../../package.json'
2+
import pkgNative from '../../src/native/package.json'
23

3-
describe('package.json', () => {
4+
describe('web/package.json', () => {
5+
it(`doesn't have any dependency for web version`, () => {
6+
expect(Object.keys(pkg.dependencies).length).toBe(0)
7+
})
8+
})
9+
10+
describe('native/package.json', () => {
411
it(`has only one dependency which is for support react-native`, () => {
5-
expect('react-native-svg' in pkg.dependencies).toBe(true)
6-
expect(Object.keys(pkg.dependencies).length).toBe(1)
12+
expect('react-native-svg' in pkgNative.dependencies).toBe(true)
13+
expect(Object.keys(pkgNative.dependencies).length).toBe(1)
714
})
815
})

src/native/package.json

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,12 @@
44
"main": "./react-content-loader.native.cjs.js",
55
"module": "./react-content-loader.native.es.js",
66
"jsnext:main": "./react-content-loader.native.es.js",
7-
"types": "./native/index.d.ts"
7+
"types": "./native/index.d.ts",
8+
"dependencies": {
9+
"react-native-svg": "9.6.4"
10+
},
11+
"peerDependencies": {
12+
"react": "^16.0.0",
13+
"react-native": "^0.60.5"
14+
}
815
}

0 commit comments

Comments
 (0)