Merge pull request #156 from danilowoz/dependencies

fix(dependencies): move native dependencies to native module

Author: danilowoz

package-lock.json

@@ -47,9 +47,7 @@
     "lint": "eslint --ext .jsx --ext .ts,.tsx src/",
     "release": "semantic-release"
   },
-  "dependencies": {
-    "react-native-svg": "9.6.4"
-  },
+  "dependencies": {},
   "devDependencies": {
     "@babel/core": "7.5.5",
     "@babel/polyfill": "7.4.4",
@@ -88,6 +86,7 @@
     "react": "16.9.0",
     "react-dom": "16.9.0",
     "react-native": "0.60.5",
+    "react-native-svg": "9.11.1",
     "react-test-renderer": "16.9.0",
     "remark-emoji": "2.0.2",
     "rollup": "1.20.2",
@@ -100,8 +99,7 @@
     "typescript": "3.5.3"
   },
   "peerDependencies": {
-    "react": "^16.0.0",
-    "react-native": "^0.60.5"
+    "react": "^16.0.0"
   },
   "husky": {
     "hooks": {

package.json

@@ -1,8 +1,15 @@
 import pkg from '../../package.json'
+import pkgNative from '../../src/native/package.json'
 
-describe('package.json', () => {
+describe('web/package.json', () => {
+  it(`doesn't have any dependency for web version`, () => {
+    expect(Object.keys(pkg.dependencies).length).toBe(0)
+  })
+})
+
+describe('native/package.json', () => {
   it(`has only one dependency which is for support react-native`, () => {
-    expect('react-native-svg' in pkg.dependencies).toBe(true)
-    expect(Object.keys(pkg.dependencies).length).toBe(1)
+    expect('react-native-svg' in pkgNative.dependencies).toBe(true)
+    expect(Object.keys(pkgNative.dependencies).length).toBe(1)
   })
 })

src/__tests__/dependency.test.tsx

@@ -4,5 +4,12 @@
   "main": "./react-content-loader.native.cjs.js",
   "module": "./react-content-loader.native.es.js",
   "jsnext:main": "./react-content-loader.native.es.js",
-  "types": "./native/index.d.ts"
+  "types": "./native/index.d.ts",
+  "dependencies": {
+    "react-native-svg": "9.6.4"
+  },
+  "peerDependencies": {
+    "react": "^16.0.0",
+    "react-native": "^0.60.5"
+  }
 }