Remove data view

Author: danlooo

pathtraits/db.py

@@ -222,7 +222,6 @@ def get_pathtraits(self, path: str):
                 pathtraits.pop("path_id")
                 for k, v in pathtraits.items():
                     res[k] = v
-        print("###1 ", path, res)
         return res
 
     def put_path_id(self, path):
@@ -299,35 +298,6 @@ def put(self, table, condition=None, update=True, **kwargs):
             insert_query = f"INSERT INTO [{table}] ({keys}) VALUES ({values});"
             self.execute(insert_query)
 
-    def put_data_view(self):
-        """
-        Creates a SQL View with all denormalized traits
-        """
-        self.execute("DROP VIEW IF EXISTS DATA;")
-
-        if self.traits:
-            join_query = " ".join(
-                [
-                    f"LEFT JOIN [{x}] ON [{x}].path = _path.id \n"
-                    for x in self.traits
-                    if x != "path"
-                ]
-            )
-
-            create_view_query = f"""
-                CREATE VIEW data AS
-                SELECT _path.path, [{'], ['.join(self.traits)}]
-                FROM _path
-                {join_query};
-            """
-        else:
-            create_view_query = """
-                CREATE VIEW data AS
-                SELECT _path.path
-                FROM _path;
-            """
-        self.execute(create_view_query)
-
     def update_trait(self):
         """
         Get all traits from the database
@@ -343,7 +313,6 @@ def update_trait(self):
         else:
             traits = []
         self.traits = [list(x.values())[0] for x in traits]
-        self.put_data_view()
 
     def create_trait_table(self, trait_name, value_type):
         """

test/test.py

@@ -70,21 +70,6 @@ def test_missing_north_america(self):
         for k, v in target.items():
             self.assertEqual(source[k], v)
 
-    def test_data_view(self):
-        source = len(self.db.execute("SELECT * FROM data;").fetchall())
-        target = 8
-        self.assertEqual(source, target)
-
-    def test_data_query(self):
-        source = len(pathtraits.access.get_paths(self.db, "[score/REAL] >= 5"))
-        target = 1
-        self.assertEqual(source, target)
-
-        traits = pathtraits.access.get_paths_values(self.db, "TRUE")
-        self.assertEqual(len(traits), 3)
-        for v in traits.values():
-            self.assertTrue("path" not in v.keys())
-
 
 if __name__ == "__main__":
     unittest.main()