Skip to content

Commit 7b12bba

Browse files
committed
adding peer review feedback
1 parent d554134 commit 7b12bba

File tree

5 files changed

+21
-13
lines changed

5 files changed

+21
-13
lines changed

content/patterns/ansible-edge-gitops/_index.adoc

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,8 @@ include::modules/comm-attributes.adoc[]
2929

3030
=== Background
3131

32-
Organizations are interested in accelerating their deployment speeds and improving delivery quality in their Edge environments, where many
33-
devices may not fully or even partially embrace the GitOps philosophy. Further, there are VMs and other devices that can and should be managed
34-
with Ansible. This pattern explores some of the possibilities of using an OpenShift-based Ansible Automated Platform deployment and managing
35-
Edge devices, based on work done with a partner in the chemical space.
32+
Organizations want to accelerate their deployment and improve delivery quality in their Edge environments, where many devices have limited or no support for GitOps practices.
33+
Many virtual machines (VMs) and devices can be effectively managed with Ansible. This pattern demonstrates how to use an OpenShift-based Ansible Automation Platform deployment and manage Edge devices, based on collaboration with a partner in the chemical space.
3634

3735
This pattern uses OpenShift Virtualization (the productization of Kubevirt) to simulate the Edge environment for VMs.
3836

content/patterns/ansible-edge-gitops/ansible-automation-platform.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ localhost : ok=7 changed=0 unreachable=0 failed=0 s
9494

9595
== Pattern AAP Configuration Details
9696

97-
In this section, we describe the details of the AAP configuration we apply as part of installing the pattern. All of the configuration discussed in this section is applied by the
97+
This section describes the AAP configuration during the pattern installation. All of the configuration discussed in this section is applied by the
9898
https://github.com/validatedpatterns/ansible-edge-gitops/blob/main/scripts/ansible_load_controller.sh[ansible_load_controller.sh]
9999
script.
100100

content/patterns/ansible-edge-gitops/getting-started.adoc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ include::modules/comm-attributes.adoc[]
1717
* An OpenShift cluster
1818
** To create an OpenShift cluster, go to the https://console.redhat.com/[Red Hat Hybrid Cloud console].
1919
** Select *OpenShift \-> Red Hat OpenShift Container Platform \-> Create cluster*.
20-
* A GitHub account and a token for it with repositories permissions, to read from and write to your forks.
21-
* The Helm binary, see link:https://helm.sh/docs/intro/install/[Installing Helm]
22-
For installation tool dependencies, see link:https://validatedpatterns.io/learn/quickstart/[Patterns quick start].
20+
* A GitHub account with a personal access token that has repository read and write permissions.
21+
* The Helm binary, for instructions, see link:https://helm.sh/docs/intro/install/[Installing Helm]
22+
* Additional installation tool dependencies. For details, see link:https://validatedpatterns.io/learn/quickstart/[Patterns quick start].
2323

2424
It is desirable to have a cluster for deploying the GitOps management hub assets and a separate cluster(s) for the managed cluster(s).
2525

@@ -71,7 +71,7 @@ upstream [email protected]:validatedpatterns/ansible-edge-gitops.git (push)
7171
+
7272
[WARNING]
7373
====
74-
Do not place this file in your repository, and do not commit or push it. This would risk pushing personal credentials to GitHub.
74+
Do not add, commit, or push this file to your repository. Doing so may expose personal credentials to GitHub.
7575
====
7676
+
7777
Run the following commands:

content/patterns/ansible-edge-gitops/ideas-for-customization.adoc

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,15 @@ include::modules/comm-attributes.adoc[]
1111

1212
== Why customize the pattern
1313

14-
One of the major goals of the Red Hat patterns development process is to create modular, customizable demos. Maybe you are not interested in Ignition as an application, or you do not have kiosks but you do have other use cases that involve running containers on edge devices. Maybe you want to experiment with different releases of RHEL, or you want to do something different with Ansible Automation Platform.
14+
A key goal of the Red Hat patterns development process is to create modular, customizable demos. You can adapt them to fit your specific use cases.
15+
For example:
1516

16-
This demo in particular can be customized in a several ways that might be very interesting and here are some starter ideas with some instructions on exactly what and where changes would need to be made in the pattern to accommodate those changes.
17+
* You may not be interested in Ignition as an application.
18+
* You might not have kiosks, but you have other edge computing use cases involving containers.
19+
* You may want to experiment with different RHEL releases.
20+
* You might want to explore alternative use cases for Ansible Automation Platform.
21+
22+
This demo offers several customization options. Here are some starter ideas, along with instructions on what to change and where to make those changes in the pattern.
1723

1824
== Defining your own VM sets using the chart
1925

content/patterns/ansible-edge-gitops/installation-details.adoc

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,15 @@ The playbook code is https://github.com/validatedpatterns/ansible-edge-gitops/bl
2727

2828
This Ansible Playbook deploys a node to run the Virtual Machines for the demo. The playbook uses the OpenShift machineset API to provision the node in the first availability zone it finds. Currently, AWS is the only major public cloud provider that offers the deployment of a metal node through the normal provisioning process. We hope that Azure and GCP will support this functionality soon.
2929

30-
Be aware that the metal node is rather more expensive in compute costs than most other AWS machine types. The trade-off is that running the demo without hardware acceleration would take ~4x as long. It takes about 20-30 minutes for the metal node to become available to run VMs. If you want to see the current status of the metal node, you can check it this way (assuming your `kubeconfig` is currently set up to point to your cluster):
30+
[NOTE]
31+
====
32+
Metal nodes are more expensive than standard AWS instances. However, running the demo without hardware acceleration can take about ~4x as long. It usually takes 20-30 minutes for the metal node to become available to run VMs.
33+
====
3134

35+
Assuming your `kubeconfig` is currently set up to point to your cluster, list all MachineSets across all namespaces in an OpenShift cluster, using the following command:
3236
[source,shell]
3337
----
34-
oc get -A machineset
38+
$ oc get -A machineset
3539
----
3640

3741
You are looking for a machineset with `metal-worker` in its name:

0 commit comments

Comments
 (0)