#44 — Remove duplicated call_user_func_array_code

Author: Jefersson Nathan

src/Route.php

@@ -20,6 +20,7 @@
 use Fig\Http\Message\RequestMethodInterface;
 use Exception;
 use Interop\Container\ContainerInterface;
+use SebastianBergmann\GlobalState\RuntimeException;
 
 class Route
 {
@@ -213,6 +214,12 @@ public function setParameters(array $parameters)
 
     public function dispatch()
     {
+        if (null === $this->getAction()) {
+            throw new RuntimeException(
+                sprintf('Could not find an action to controller "%s"', $this->controller)
+            );
+        }
+
         if ($this->parametersByName) {
             $this->parameters = array($this->parameters);
         }
@@ -221,6 +228,11 @@ public function dispatch()
 
         if ($this->container && $this->container->has($controller)) {
             $instance = $this->container->get($controller);
+        } else {
+            $instance = new $controller;
+        }
+
+        if (method_exists($this, $this->getAction())){
             call_user_func_array(
                 array($instance, $this->getAction()),
                 $this->parameters
@@ -229,12 +241,7 @@ public function dispatch()
             return;
         }
 
-        if (!is_null($this->getAction())) {
-            $instance = new $controller;
-            call_user_func_array(array($instance, $this->getAction()), $this->parameters);
-        } else {
-            $instance = new $controller($this->parameters);
-        }
+        new $controller($this->parameters);
     }
 
     public function getAction()