Code cleanup

Author: danopdev

app/src/main/java/com/dan/perspective/AppFragment.kt

@@ -3,7 +3,7 @@ package com.dan.perspective
 import androidx.fragment.app.Fragment
 
 open class AppFragment(val activity: MainActivity) : Fragment() {
-    open fun onBack(backButton: Boolean) {
+    open fun onBack(homeButton: Boolean) {
     }
 
     fun showToast(message: String) {

app/src/main/java/com/dan/perspective/MainActivity.kt

@@ -29,13 +29,13 @@ class MainActivity : AppCompatActivity() {
     private val stack = mutableListOf<Pair<String, AppFragment>>()
     val settings: Settings by lazy { Settings(this) }
 
-    private fun popView(callOnBack: Boolean = false, backButton: Boolean = false): Boolean {
+    private fun popView(homeButton: Boolean = false): Boolean {
         if (stack.size <= 1) return false
 
         val prevFragment = stack.removeLast().second
         val item = stack.last()
 
-        if (callOnBack) prevFragment.onBack(backButton)
+        prevFragment.onBack(homeButton)
 
         val transaction = supportFragmentManager.beginTransaction()
         transaction.show(item.second)
@@ -71,15 +71,15 @@ class MainActivity : AppCompatActivity() {
 
     override fun onOptionsItemSelected(item: MenuItem): Boolean {
         if (android.R.id.home == item.itemId) {
-            popView(true, true)
+            popView(true)
             return true
         }
 
         return super.onOptionsItemSelected(item)
     }
 
     override fun onBackPressed() {
-        if (!popView(true, false)) super.onBackPressed()
+        if (!popView(false)) super.onBackPressed()
     }
 
     fun giveHapticFeedback(view: View) {

app/src/main/java/com/dan/perspective/SettingsFragment.kt

@@ -22,7 +22,7 @@ class SettingsFragment(activity: MainActivity) : AppFragment(activity) {
     private val settings = activity.settings
     private lateinit var binding: SettingsFragmentBinding
 
-    override fun onBack(backButton: Boolean) {
+    override fun onBack(homeButton: Boolean) {
         if (binding.radioPng.isChecked) activity.settings.outputType = Settings.OUTPUT_TYPE_PNG
         else if (binding.radioTiff.isChecked) activity.settings.outputType = Settings.OUTPUT_TYPE_TIFF
         else activity.settings.outputType = Settings.OUTPUT_TYPE_JPEG