Added error handling. Added tests. Added requirements. Fixed tests

Author: bpross

gdax/authenticated_client.py

@@ -23,8 +23,7 @@ def __init__(self, key, b64secret, passphrase, api_url="https://api.gdax.com", t
 
     def get_account(self, account_id):
         r = requests.get(self.url + '/accounts/' + account_id, auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        return r.json()
+        return self._determine_response(r)
 
     def get_accounts(self):
         return self.get_account('')
@@ -33,34 +32,35 @@ def get_account_history(self, account_id):
         result = []
         r = requests.get(self.url + '/accounts/{}/ledger'.format(account_id), auth=self.auth, timeout=self.timeout)
         # r.raise_for_status()
-        result.append(r.json())
+        r_json = self._determine_response(r)
+        result.append(r_json)
         if "cb-after" in r.headers:
             self.history_pagination(account_id, result, r.headers["cb-after"])
         return result
 
     def history_pagination(self, account_id, result, after):
         r = requests.get(self.url + '/accounts/{}/ledger?after={}'.format(account_id, str(after)), auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        if r.json():
-            result.append(r.json())
+        r_json = self._determine_response(r)
+        if r_json:
+            result.append(r_json)
         if "cb-after" in r.headers:
             self.history_pagination(account_id, result, r.headers["cb-after"])
         return result
 
     def get_account_holds(self, account_id):
         result = []
         r = requests.get(self.url + '/accounts/{}/holds'.format(account_id), auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        result.append(r.json())
+        r_json = self._determine_response(r)
+        result.append(r_json)
         if "cb-after" in r.headers:
             self.holds_pagination(account_id, result, r.headers["cb-after"])
         return result
 
     def holds_pagination(self, account_id, result, after):
         r = requests.get(self.url + '/accounts/{}/holds?after={}'.format(account_id, str(after)), auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        if r.json():
-            result.append(r.json())
+        r_json = self._determine_response(r)
+        if r_json:
+            result.append(r_json)
         if "cb-after" in r.headers:
             self.holds_pagination(account_id, result, r.headers["cb-after"])
         return result
@@ -73,34 +73,31 @@ def buy(self, **kwargs):
                           data=json.dumps(kwargs),
                           auth=self.auth,
                           timeout=self.timeout)
-        return r.json()
+        return self._determine_response(r)
 
     def sell(self, **kwargs):
         kwargs["side"] = "sell"
         r = requests.post(self.url + '/orders',
                           data=json.dumps(kwargs),
                           auth=self.auth,
                           timeout=self.timeout)
-        return r.json()
+        return self._determine_response(r)
 
     def cancel_order(self, order_id):
         r = requests.delete(self.url + '/orders/' + order_id, auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        return r.json()
+        return self._determine_response(r)
 
     def cancel_all(self, product_id=''):
         url = self.url + '/orders/'
         params = {}
         if product_id:
             params["product_id"] = product_id
         r = requests.delete(url, auth=self.auth, params=params, timeout=self.timeout)
-        # r.raise_for_status()
-        return r.json()
+        return self._determine_response(r)
 
     def get_order(self, order_id):
         r = requests.get(self.url + '/orders/' + order_id, auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        return r.json()
+        return self._determine_response(r)
 
     def get_orders(self, product_id='', status=[]):
         result = []
@@ -111,8 +108,8 @@ def get_orders(self, product_id='', status=[]):
         if status:
             params["status"] = status
         r = requests.get(url, auth=self.auth, params=params, timeout=self.timeout)
-        # r.raise_for_status()
-        result.append(r.json())
+        r_json = self._determine_response(r)
+        result.append(r_json)
         if 'cb-after' in r.headers:
             self.paginate_orders(product_id, status, result, r.headers['cb-after'])
         return result
@@ -128,9 +125,9 @@ def paginate_orders(self, product_id, status, result, after):
         if status:
             params["status"] = status
         r = requests.get(url, auth=self.auth, params=params, timeout=self.timeout)
-        # r.raise_for_status()
-        if r.json():
-            result.append(r.json())
+        r_json = self._determine_response(r)
+        if r_json:
+            result.append(r_json)
         if 'cb-after' in r.headers:
             self.paginate_orders(product_id, status, result, r.headers['cb-after'])
         return result
@@ -149,9 +146,9 @@ def get_fills(self, order_id='', product_id='', before='', after='', limit=''):
         if limit:
             url += "limit={}&".format(str(limit))
         r = requests.get(url, auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        result.append(r.json())
-        if 'cb-after' in r.headers and limit is not len(r.json()):
+        r_json = self._determine_response(r)
+        result.append(r_json)
+        if 'cb-after' in r.headers and limit is not len(r_json):
             return self.paginate_fills(result, r.headers['cb-after'], order_id=order_id, product_id=product_id)
         return result
 
@@ -162,9 +159,9 @@ def paginate_fills(self, result, after, order_id='', product_id=''):
         if product_id:
             url += "product_id={}&".format(product_id)
         r = requests.get(url, auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        if r.json():
-            result.append(r.json())
+        r_json = self._determine_response(r)
+        if r_json:
+            result.append(r_json)
         if 'cb-after' in r.headers:
             return self.paginate_fills(result, r.headers['cb-after'], order_id=order_id, product_id=product_id)
         return result
@@ -178,8 +175,8 @@ def get_fundings(self, result='', status='', after=''):
         if after:
             url += 'after={}&'.format(str(after))
         r = requests.get(url, auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        result.append(r.json())
+        r_json = self._determine_response(r)
+        result.append(r_json)
         if 'cb-after' in r.headers:
             return self.get_fundings(result, status=status, after=r.headers['cb-after'])
         return result
@@ -190,8 +187,7 @@ def repay_funding(self, amount='', currency=''):
             "currency": currency  # example: USD
         }
         r = requests.post(self.url + "/funding/repay", data=json.dumps(payload), auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        return r.json()
+        return self._determine_response(r)
 
     def margin_transfer(self, margin_profile_id="", transfer_type="", currency="", amount=""):
         payload = {
@@ -201,21 +197,18 @@ def margin_transfer(self, margin_profile_id="", transfer_type="", currency="", a
             "amount": amount
         }
         r = requests.post(self.url + "/profiles/margin-transfer", data=json.dumps(payload), auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        return r.json()
+        return self._determine_response(r)
 
     def get_position(self):
         r = requests.get(self.url + "/position", auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        return r.json()
+        return self._determine_response(r)
 
     def close_position(self, repay_only=""):
         payload = {
             "repay_only": repay_only or False
         }
         r = requests.post(self.url + "/position/close", data=json.dumps(payload), auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        return r.json()
+        return self._determine_response(r)
 
     def deposit(self, amount="", currency="", payment_method_id=""):
         payload = {
@@ -224,8 +217,7 @@ def deposit(self, amount="", currency="", payment_method_id=""):
             "payment_method_id": payment_method_id
         }
         r = requests.post(self.url + "/deposits/payment-method", data=json.dumps(payload), auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        return r.json()
+        return self._determine_response(r)
 
     def coinbase_deposit(self, amount="", currency="", coinbase_account_id=""):
         payload = {
@@ -234,8 +226,7 @@ def coinbase_deposit(self, amount="", currency="", coinbase_account_id=""):
             "coinbase_account_id": coinbase_account_id
         }
         r = requests.post(self.url + "/deposits/coinbase-account", data=json.dumps(payload), auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        return r.json()
+        return self._determine_response(r)
 
     def withdraw(self, amount="", currency="", payment_method_id=""):
         payload = {
@@ -244,8 +235,7 @@ def withdraw(self, amount="", currency="", payment_method_id=""):
             "payment_method_id": payment_method_id
         }
         r = requests.post(self.url + "/withdrawals/payment-method", data=json.dumps(payload), auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        return r.json()
+        return self._determine_response(r)
 
     def coinbase_withdraw(self, amount="", currency="", coinbase_account_id=""):
         payload = {
@@ -254,8 +244,7 @@ def coinbase_withdraw(self, amount="", currency="", coinbase_account_id=""):
             "coinbase_account_id": coinbase_account_id
         }
         r = requests.post(self.url + "/withdrawals/coinbase-account", data=json.dumps(payload), auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        return r.json()
+        return self._determine_response(r)
 
     def crypto_withdraw(self, amount="", currency="", crypto_address=""):
         payload = {
@@ -264,18 +253,15 @@ def crypto_withdraw(self, amount="", currency="", crypto_address=""):
             "crypto_address": crypto_address
         }
         r = requests.post(self.url + "/withdrawals/crypto", data=json.dumps(payload), auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        return r.json()
+        return self._determine_response(r)
 
     def get_payment_methods(self):
         r = requests.get(self.url + "/payment-methods", auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        return r.json()
+        return self._determine_response(r)
 
     def get_coinbase_accounts(self):
         r = requests.get(self.url + "/coinbase-accounts", auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        return r.json()
+        return self._determine_response(r)
 
     def create_report(self, report_type="", start_date="", end_date="", product_id="", account_id="", report_format="",
                       email=""):
@@ -289,20 +275,16 @@ def create_report(self, report_type="", start_date="", end_date="", product_id="
             "email": email
         }
         r = requests.post(self.url + "/reports", data=json.dumps(payload), auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        return r.json()
+        return self._determine_response(r)
 
     def get_report(self, report_id=""):
         r = requests.get(self.url + "/reports/" + report_id, auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        return r.json()
+        return self._determine_response(r)
 
     def get_trailing_volume(self):
         r = requests.get(self.url + "/users/self/trailing-volume", auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        return r.json()
+        return self._determine_response(r)
 
     def get_deposit_address(self, account_id):
         r = requests.post(self.url + '/coinbase-accounts/{}/addresses'.format(account_id), auth=self.auth, timeout=self.timeout)
-        # r.raise_for_status()
-        return r.json()
+        return self._determine_response(r)

gdax/exceptions.py

@@ -0,0 +1,75 @@
+class GdaxException(Exception):
+    """
+    Base GDAX Exception
+    Raised when Bad Response returned from GDAX
+    See: https://docs.gdax.com/?python#errors
+    """
+
+    def __init__(self, message, code):
+        """
+        :param message: Message from GDAX response
+        :type message: str
+        :param code: HTTP Code
+        :type code: int
+        """
+        self._message = message
+        self._code = code
+
+    @property
+    def message(self):
+        return self._message
+
+    @message.setter
+    def message(self, message):
+        self._message = message
+
+
+    @property
+    def code(self):
+        return self._code
+
+    @message.setter
+    def message(self, code):
+        self._code = code
+
+
+class InvalidGdaxRequest(GdaxException):
+    """
+    Raised on 400 response from GDAX
+    """
+    pass
+
+
+class UnauthorizedGdaxRequest(GdaxException):
+    """
+    Raised on 401 response from GDAX
+    """
+    pass
+
+
+class ForbiddenGdaxRequest(GdaxException):
+    """
+    Raised on 403 response from GDAX
+    """
+    pass
+
+
+class NotFoundGdaxRequest(GdaxException):
+    """
+    Raised on 404 response from GDAX
+    """
+    pass
+
+
+class UnknownGdaxClientRequest(GdaxException):
+    """
+    Raised on 4XX responses not tracked
+    """
+    pass
+
+
+class InternalErrorGdaxRequest(GdaxException):
+    """
+    Raised on 500 response from GDAX
+    """
+    pass