-
-
Notifications
You must be signed in to change notification settings - Fork 71
Implement PKCE #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Implement PKCE #91
Conversation
|
Aww man! I was going to implement this, but you beat me to it. |
|
I think it would be a good idea to add a test with the examples in Appendix A and Appendix B. |
I'll see If I have time later for this. But feel free to contribute with the tests if you need it right away :) |
I'm still new to Elixir, but I may give it a try later :) |
|
Waiting for this to be merged to upstream. A very good PR! Just one note.
What do you think? |
|
@Ross65536 Made a PR to your repo :) |
Implement PKCE for authorization code grant type, as per RFC-7637:
code_challengeandcode_challenge_methodtooauth_access_grantstable which will contain the PKCE information. Add instructions for upgrading.use_pkce. Iftruewhen issuing grants thecode_challengeandcode_challenge_methodquery fields are mandatory and are saved to the grant model. Iffalsethese fields are ignored and the corresponding grant models are set tonilcode_challenge_methodfield set. If set to a value not nil then thecode_verifierquery field is mandatory and it's used to check against the grant'scode_challengefield. If set to nil this query parameter is ignored and the grant acts as though PKCE is disabled.Partially inspired by #61