Bind :host to IPv6 localhost

Author: danschultzer

CHANGELOG.md

@@ -1,6 +1,8 @@
 ## v0.1.9 (TBA)
 
 - `:httpd` server adapter now parses remote ip to tuple format
+- `:httpd` server adapter now parses host from host header
+- Specifying `:host` now also binds the hostname to IPv6 loopback
 - Added `:ipfamily` option to set IP address type to use
 
 ## v0.1.8 (2023-02-10)

lib/test_server.ex

@@ -160,7 +160,7 @@ defmodule TestServer do
   Produces a URL for current test server.
 
   ## Options
-    * `:host` - binary host value, it'll be added to inet for IP 127.0.0.1, defaults to `"localhost"`;
+    * `:host` - binary host value, it'll be added to inet for IP `127.0.0.1` and `::1`, defaults to `"localhost"`;
   """
   @spec url(binary(), keyword()) :: binary()
   def url(uri, opts) when is_binary(uri), do: url(fetch_instance!(), uri, opts)
@@ -237,6 +237,7 @@ defmodule TestServer do
   defp maybe_enable_host(host) do
     :inet_db.set_lookup([:file, :dns])
     :inet_db.add_host({127, 0, 0, 1}, [String.to_charlist(host)])
+    :inet_db.add_host({0, 0, 0, 0, 0, 0, 0, 1}, [String.to_charlist(host)])
 
     host
   end

lib/test_server/http_server/httpd.ex

@@ -108,9 +108,20 @@ defmodule TestServer.HTTPServer.Httpd do
   end
 
   defp host(data) do
-    {:init_data, _, host, _} = httpd(data, :init_data)
+    data
+    |> httpd(:parsed_header)
+    |> Enum.find(&elem(&1, 0) == 'host')
+    |> Kernel.||({'host', ''})
+    |> elem(1)
+    |> to_string()
+    |> :binary.split(":")
+    |> case do
+      [host, port] ->
+        {Integer.parse(port), host}
 
-    host
+      [host] ->
+        {nil, host}
+    end
   end
 
   defp peer(data) do

test/test_server_test.exs

@@ -47,7 +47,7 @@ defmodule TestServerTest do
 
       assert %X509.Test.Suite{} = options[:x509_suite]
 
-      httpc_opts = fn cacerts ->
+      http_opts = fn cacerts ->
         [
           ssl: [
             verify: :verify_peer,
@@ -65,10 +65,10 @@ defmodule TestServerTest do
       invalid_cacerts = X509.Test.Suite.new().cacerts
 
       assert {:error, {:failed_connect, _}} =
-               request(TestServer.url("/"), httpc_opts: httpc_opts.(invalid_cacerts))
+               request(TestServer.url("/"), http_opts: http_opts.(invalid_cacerts))
 
       assert :ok = TestServer.add("/")
-      assert {:ok, _} = request(TestServer.url("/"), httpc_opts: httpc_opts.(valid_cacerts))
+      assert {:ok, _} = request(TestServer.url("/"), http_opts: http_opts.(valid_cacerts))
     end
 
     test "starts in IPv6-only mode`" do
@@ -165,7 +165,7 @@ defmodule TestServerTest do
       end
     end
 
-    test "invalid `:host`" do
+    test "with invalid `:host`" do
       TestServer.start()
 
       assert_raise RuntimeError, ~r/Invalid host, got: :invalid/, fn ->
@@ -181,6 +181,32 @@ defmodule TestServerTest do
       refute TestServer.url("/") == TestServer.url("/", host: "bad-host")
     end
 
+    test "with `:host`" do
+      TestServer.start()
+
+      assert :ok = TestServer.add("/", to: fn conn ->
+        assert conn.remote_ip == {127, 0, 0, 1}
+        assert conn.host == "custom-host"
+
+        Plug.Conn.send_resp(conn, 200, "OK")
+      end)
+
+      assert {:ok, _} = request(TestServer.url("/", host: "custom-host"))
+    end
+
+    test "with `:host` in IPv6-only mode" do
+      TestServer.start(ipfamily: :inet6, http_server: {TestServer.HTTPServer.Httpd, []})
+
+      assert :ok = TestServer.add("/", to: fn conn ->
+        assert conn.remote_ip == {0, 0, 0, 0, 0, 65_535, 32_512, 1}
+        assert conn.host == "custom-host"
+
+        Plug.Conn.send_resp(conn, 200, "OK")
+      end)
+
+      assert {:ok, _} = request(TestServer.url("/", host: "custom-host"))
+    end
+
     test "with multiple instances" do
       {:ok, instance_1} = TestServer.start()
       {:ok, instance_2} = TestServer.start()
@@ -691,13 +717,14 @@ defmodule TestServerTest do
 
   def request(url, opts \\ []) do
     url = String.to_charlist(url)
-    httpc_opts = Keyword.get(opts, :httpc_opts, [])
+    httpc_http_opts = Keyword.get(opts, :http_opts, [])
+    httpc_opts = Keyword.get(opts, :opts, [])
 
     opts
     |> Keyword.get(:method, :get)
     |> case do
-      :post -> :httpc.request(:post, {url, [], 'plain/text', 'OK'}, httpc_opts, [])
-      :get -> :httpc.request(:get, {url, []}, httpc_opts, [])
+      :post -> :httpc.request(:post, {url, [], 'plain/text', 'OK'}, httpc_http_opts, httpc_opts)
+      :get -> :httpc.request(:get, {url, []}, httpc_http_opts, httpc_opts)
     end
     |> case do
       {:ok, {{_, 200, _}, _headers, body}} -> {:ok, to_string(body)}