add snapshot features

Create snapshot and verify
Implement From traits for common error conversions

Author: virjilakrum

Cargo.toml

@@ -5,7 +5,7 @@ edition = "2021"
 
 [dependencies]
 tokio = { version = "1.36", features = ["full"] }
-virt = "0.4.1"  
+virt = { version = "0.4.1", features = ["snapshot"] }
 serde = { version = "1.0", features = ["derive"] }
 serde_json = "1.0"
 tracing = "0.1"

src/core/errors.rs

@@ -18,15 +18,14 @@ pub enum GpuShareError {
     UnknownError(String),
 }
 
-// Implement From traits for common error conversions
-impl From<libvirt::error::Error> for GpuShareError {
-    fn from(err: libvirt::error::Error) -> Self {
-        GpuShareError::ConnectionError(err.to_string())
-    }
-}
-
 impl From<std::io::Error> for GpuShareError {
     fn from(err: std::io::Error) -> Self {
         GpuShareError::ConfigError(err.to_string())
     }
-} 
+}
+
+impl From<virt::error::Error> for GpuShareError {
+    fn from(error: virt::error::Error) -> Self {
+        GpuShareError::ConnectionError(error.to_string())
+    }
+}

src/core/libvirt.rs

@@ -6,6 +6,7 @@ use crate::core::vm::VMConfig;
 // use virt::sys;
 
 // time to manage some VMs! >.
+#[derive(Clone)]
 #[allow(dead_code)]  
 pub struct LibvirtManager {
     conn: Connect,
@@ -78,12 +79,10 @@ impl LibvirtManager {
     }
 
     pub fn lookup_domain(&self, id: &str) -> Result<Domain> {
-        // Önce UUID olarak dene
         if let Ok(domain) = Domain::lookup_by_uuid_string(&self.conn, id) {
             return Ok(domain);
         }
 
-        // UUID olarak bulunamazsa isim olarak dene
         match Domain::lookup_by_name(&self.conn, id) {
             Ok(domain) => Ok(domain),
             Err(e) => Err(anyhow::anyhow!("Failed to find domain: {}", e))

tests/vm_tests.rs

@@ -1,7 +1,7 @@
 // Virtual Machine Test Suite - Because untested code is like Schrödinger's cat! 🐱💻
 
 use anyhow::{Context, Result};
-use gpu_share_vm_manager::core::{LibvirtManager, vm::{VMConfig, VMStatus}};
+use gpu_share_vm_manager::core::{LibvirtManager, vm::VMConfig};
 use std::path::PathBuf;
 // use tracing::{info, warn};
 use uuid::Uuid;
@@ -156,23 +156,26 @@ async fn test_vm_snapshots() -> Result<()> {
     let vm = libvirt.0.create_vm(&config).await?;
     vm.create()?;
 
-    // Create snapshot
-    let snapshot_xml = format!(r#"
-        <domainsnapshot>
-            <name>{}</name>
-            <description>{}</description>
-        </domainsnapshot>"#,
-        "test-snapshot",
-        "Initial state"
-    );
-    vm.snapshot_create_xml(&snapshot_xml, 0)?;
-
-    // Restore snapshot
-    let snapshot = vm.snapshot_lookup_by_name("test-snapshot")?;
-    vm.snapshot_revert(snapshot, 0)?;
+    // Create snapshot with proper XML structure
+    let snapshot_xml = r#"
+    <domainsnapshot>
+        <name>test-snapshot</name>
+        <description>Initial state</description>
+        <memory snapshot='no'/>
+    </domainsnapshot>"#;
 
-    let restored_xml = vm.get_xml_desc(0)?;
-    assert_eq!(restored_xml, vm.get_xml_desc(0)?, "XML should match snapshot");
+    // Create snapshot and verify
+    let snapshot = vm.snapshot_create_xml(snapshot_xml, 0)
+        .context("Failed to create snapshot")?;
+    assert_eq!(snapshot.get_name()?, "test-snapshot");
+
+    // Revert to snapshot
+    vm.snapshot_revert(snapshot, 0)
+        .context("Failed to revert snapshot")?;
+
+    // Cleanup snapshot
+    let current_snapshot = vm.snapshot_current(0)?;
+    current_snapshot.delete(0)?;
 
     vm.destroy()?;
     vm.undefine()?;