Fix FormEditor.dispose() calling super.dispose() first

Common pattern for init/dispose, setup/teardown is that on init, super
is called first and on dispose last.

This is always done this way to allow super class initialize whatever
needed first and subclass work on that, and the dispose should always
perform cleanup in the opposite direction. Otherwise super code might
cleanup things that are still needed for the subclass to properly
cleanup.

Probably related to
eclipse-pde/eclipse.pde#1963

Author: iloveeclipse

bundles/org.eclipse.ui.forms/src/org/eclipse/ui/forms/editor/FormEditor.java

@@ -400,7 +400,6 @@ public void editorDirtyStateChanged() {
 	 */
 	@Override
 	public void dispose() {
-		super.dispose();
 		for (Object page : pages) {
 			if (page instanceof IFormPage) {
 				IFormPage fpage = (IFormPage) page;
@@ -417,6 +416,7 @@ public void dispose() {
 			toolkit.dispose();
 			toolkit = null;
 		}
+		super.dispose();
 	}
 
 	/**