Apply clippy things

Author: dantleech

src/app.rs

@@ -676,12 +676,9 @@ impl App {
         self.workspace.reset();
     }
 
-    fn recenter(&mut self) -> () {
+    fn recenter(&mut self) {
         let entry = self.history.current();
-        match entry {
-            Some(entry) => self.session_view.scroll_to_line(entry.source(self.session_view.stack_depth()).line_no),
-            None => (),
-        }
+        if let Some(entry) = entry { self.session_view.scroll_to_line(entry.source(self.session_view.stack_depth()).line_no) }
     }
 }
 

src/config.rs

@@ -40,7 +40,7 @@ mod test {
     use crate::notification::Notification;
 
     #[test]
-    fn test_countdown_char() -> () {
+    fn test_countdown_char() {
         let notification = Notification::info("Hello".to_string());
         notification.countdown_char();
     }

src/dbgp/client.rs

@@ -212,7 +212,7 @@ impl DbgpClient {
     }
 
     pub(crate) async fn run(&mut self) -> Result<ContinuationResponse> {
-        match self.command("run", &mut vec![]).await? {
+        match self.command("run", &mut []).await? {
             Message::Response(r) => match r.command {
                 CommandResponse::Run(s) => Ok(s),
                 _ => anyhow::bail!("Unexpected response"),
@@ -223,7 +223,7 @@ impl DbgpClient {
 
     pub(crate) async fn feature_set(&mut self, feature: &str, value: &str) -> Result<()> {
         match self
-            .command("feature_set", &mut vec!["-n", feature, "-v", value])
+            .command("feature_set", &mut ["-n", feature, "-v", value])
             .await?
         {
             Message::Response(r) => match r.command {
@@ -235,7 +235,7 @@ impl DbgpClient {
     }
 
     pub(crate) async fn context_get(&mut self, depth: u16) -> Result<ContextGetResponse> {
-        match self.command("context_get", &mut vec!["-d", format!("{}", depth).as_str()]).await? {
+        match self.command("context_get", &mut ["-d", format!("{}", depth).as_str()]).await? {
             Message::Response(r) => match r.command {
                 CommandResponse::ContextGet(s) => Ok(s),
                 _ => anyhow::bail!("Unexpected response"),
@@ -245,7 +245,7 @@ impl DbgpClient {
     }
 
     pub(crate) async fn step_into(&mut self) -> Result<ContinuationResponse> {
-        match self.command("step_into", &mut vec![]).await? {
+        match self.command("step_into", &mut []).await? {
             Message::Response(r) => match r.command {
                 CommandResponse::StepInto(s) => Ok(s),
                 _ => anyhow::bail!("Unexpected response"),
@@ -255,7 +255,7 @@ impl DbgpClient {
     }
 
     pub(crate) async fn step_out(&mut self) -> Result<ContinuationResponse> {
-        match self.command("step_out", &mut vec![]).await? {
+        match self.command("step_out", &mut []).await? {
             Message::Response(r) => match r.command {
                 CommandResponse::StepInto(s) => Ok(s),
                 _ => anyhow::bail!("Unexpected response"),
@@ -265,7 +265,7 @@ impl DbgpClient {
     }
 
     pub(crate) async fn step_over(&mut self) -> Result<ContinuationResponse> {
-        match self.command("step_over", &mut vec![]).await? {
+        match self.command("step_over", &mut []).await? {
             Message::Response(r) => match r.command {
                 CommandResponse::StepOver(s) => Ok(s),
                 _ => anyhow::bail!("Unexpected response"),
@@ -275,7 +275,7 @@ impl DbgpClient {
     }
 
     pub(crate) async fn get_stack(&mut self) -> Result<StackGetResponse> {
-        match self.command("stack_get", &mut vec!["-n 0"]).await? {
+        match self.command("stack_get", &mut ["-n 0"]).await? {
             Message::Response(r) => match r.command {
                 CommandResponse::StackGet(s) => Ok(s),
                 _ => anyhow::bail!("Unexpected response"),
@@ -286,7 +286,7 @@ impl DbgpClient {
 
     pub(crate) async fn source(&mut self, filename: String) -> Result<String> {
         match self
-            .command("source", &mut vec![format!("-f {}", filename).as_str()])
+            .command("source", &mut [format!("-f {}", filename).as_str()])
             .await?
         {
             Message::Response(r) => match r.command {
@@ -297,12 +297,12 @@ impl DbgpClient {
         }
     }
 
-    async fn command(&mut self, cmd: &str, args: &mut Vec<&str>) -> Result<Message> {
+    async fn command(&mut self, cmd: &str, args: &mut [&str]) -> Result<Message> {
         self.command_raw(cmd, args).await?;
         self.read_and_parse().await
     }
 
-    async fn command_raw(&mut self, cmd: &str, args: &mut Vec<&str>) -> Result<usize> {
+    async fn command_raw(&mut self, cmd: &str, args: &mut [&str]) -> Result<usize> {
         let cmd_str = format!("{} -i {} {}", cmd, self.tid, args.join(" "));
         debug!("[dbgp] >> {}", cmd_str);
         let bytes = [cmd_str.trim_end(), "\0"].concat();

src/notification.rs

@@ -78,7 +78,7 @@ mod test {
     use pretty_assertions::assert_eq;
 
     #[test]
-    fn test_countdown_char() -> () {
+    fn test_countdown_char() {
         let notification = Notification::info("hello".to_string());
         assert_eq!('█', notification.countdown_char());
 

src/view/session.rs

@@ -12,7 +12,6 @@ use crate::app::App;
 use crate::app::ListenStatus;
 use crate::app::SelectedView;
 use crate::event::input::AppEvent;
-use clap::builder::ArgPredicate;
 use crossterm::event::KeyCode;
 use ratatui::layout::Constraint;
 use ratatui::layout::Layout;
@@ -137,7 +136,7 @@ fn split_rows(panes: &Vec<&Pane>, area: Rect) -> Rc<[Rect]> {
             vertical_constraints.push(pane.constraint);
         }
 
-        return Layout::vertical(vertical_constraints).split(area);
+        Layout::vertical(vertical_constraints).split(area)
 }
 
 fn delegate_event_to_pane(app: &mut App, event: AppEvent) -> Option<AppEvent> {
@@ -294,7 +293,7 @@ impl SessionViewState {
         self.stack_scroll.0
     }
 
-    pub(crate) fn scroll_to_line(&mut self, line_no: u32) -> () {
+    pub(crate) fn scroll_to_line(&mut self, line_no: u32) {
         let area = self.source_area.get();
         let mid_point = (area.height as u32).div_ceil(2);
         let offset = if line_no > mid_point {
@@ -318,7 +317,7 @@ mod test {
     use super::*;
 
     #[test]
-    pub fn panes() -> () {
+    pub fn panes() {
         let mut view = SessionViewState::default();
         view.panes = vec![
             Pane{ component_type: ComponentType::Stack, constraint: Constraint::Min(1), col: Col::Left},
@@ -330,7 +329,7 @@ mod test {
     }
 
     #[test]
-    pub fn scroll_to_line() -> () {
+    pub fn scroll_to_line() {
         let mut view = SessionViewState::default();
         view.source_area = Cell::new(Rect{
             x: 0,