feat(rpc): expose missing response groups on timeout (#604)

Author: marcus-pousette

packages/programs/rpc/src/utils.ts

@@ -13,8 +13,10 @@ import type {
 } from "./io.js";
 
 export class MissingResponsesError extends Error {
-	constructor(message: string) {
+	missingGroups: string[][];
+	constructor(message: string, missingGroups: string[][] = []) {
 		super(message);
+		this.missingGroups = missingGroups;
 	}
 }
 export type RPCRequestAllOptions<_Q, R> = RPCRequestResponseOptions<R> &
@@ -84,6 +86,7 @@ export const queryAll = async <Q, R>(
 		throw new MissingResponsesError(
 			"Did not receive responses from all shards: " +
 				JSON.stringify(missingReponses),
+			missingReponses,
 		);
 	}
 };

packages/programs/rpc/test/index.spec.ts

@@ -11,6 +11,7 @@ import { TestSession } from "@peerbit/test-utils";
 import { AbortError, delay, waitFor, waitForResolved } from "@peerbit/time";
 import { expect } from "chai";
 import {
+	MissingResponsesError,
 	RPC,
 	type RPCResponse,
 	type RequestEvent,
@@ -734,4 +735,24 @@ describe("queryAll", () => {
 		await expect(promise).rejectedWith("TestAborted");
 		expect(+new Date() - t1).lessThan(1000);
 	});
+
+	it("reports missing groups on timeout", async () => {
+		clients[1].delay = 200;
+		const missingGroup = [[clients[1].node.identity.publicKey.hashcode()]];
+		try {
+			await queryAll(
+				clients[0].query,
+				missingGroup,
+				new Body({ arr: new Uint8Array([1]) }),
+				() => {},
+				{ timeout: 50 },
+			);
+			expect.fail("Expected MissingResponsesError");
+		} catch (error) {
+			expect(error).to.be.instanceOf(MissingResponsesError);
+			expect((error as MissingResponsesError).missingGroups).to.deep.equal(
+				missingGroup,
+			);
+		}
+	});
 });