refactor(shared-log): remove persistCoordinate hash guard fallback

Author: marcus-pousette

packages/programs/data/shared-log/src/index.ts

@@ -4498,27 +4498,7 @@ export class SharedLog<
 			return; // no change
 		}
 
-		const entryHash = (properties.entry as any)?.hash;
-		if (typeof entryHash !== "string" || entryHash.length === 0) {
-			warn("Skipping persistCoordinate for entry without hash");
-			return;
-		}
-
-		let cidObject: ReturnType<typeof cidifyString>;
-		try {
-			cidObject = cidifyString(entryHash);
-		} catch (error) {
-			warn(
-				`Skipping persistCoordinate for invalid hash '${entryHash}': ${
-					(error as any)?.message ?? error
-				}`,
-			);
-			return;
-		}
-		if (!cidObject?.multihash?.digest) {
-			warn(`Skipping persistCoordinate for entry '${entryHash}' without digest`);
-			return;
-		}
+		const cidObject = cidifyString(properties.entry.hash);
 		const hashNumber = this.indexableDomain.numbers.bytesToNumber(
 			cidObject.multihash.digest,
 		);
@@ -4528,19 +4508,22 @@ export class SharedLog<
 				assignedToRangeBoundary,
 				coordinates: properties.coordinates,
 				meta: properties.entry.meta,
-				hash: entryHash,
+				hash: properties.entry.hash,
 				hashNumber,
 			}),
 		);
 
 		for (const coordinate of properties.coordinates) {
-			this.coordinateToHash.add(coordinate, entryHash);
+			this.coordinateToHash.add(coordinate, properties.entry.hash);
 		}
 
-		const next = properties.entry.meta?.next ?? [];
-		if (next.length > 0) {
+		if (properties.entry.meta.next.length > 0) {
 			await this.entryCoordinatesIndex.del({
-				query: new Or(next.map((x) => new StringMatch({ key: "hash", value: x }))),
+				query: new Or(
+					properties.entry.meta.next.map(
+						(x) => new StringMatch({ key: "hash", value: x }),
+					),
+				),
 			});
 		}
 	}

packages/programs/data/shared-log/test/wait-for-replicator.spec.ts

@@ -85,32 +85,4 @@ describe("waitForReplicator", () => {
 		}
 	});
 
-	it("ignores persistCoordinate for missing or invalid hashes", async () => {
-		session = await TestSession.connected(1);
-		db = await session.peers[0].open(new EventStore<string, any>(), {
-			args: {
-				timeUntilRoleMaturity: 0,
-			},
-		});
-
-		const persistCoordinate = (db.log as any).persistCoordinate.bind(db.log);
-
-		await expect(
-			persistCoordinate({
-				coordinates: [0n],
-				entry: { hash: undefined, meta: { next: [] } },
-				leaders: new Map(),
-				replicas: 1,
-			}),
-		).to.not.be.rejected;
-
-		await expect(
-			persistCoordinate({
-				coordinates: [0n],
-				entry: { hash: "not-a-cid", meta: { next: [] } },
-				leaders: new Map(),
-				replicas: 1,
-			}),
-		).to.not.be.rejected;
-	});
 });