Fix min constraints being 100% (#761)

Related to #742

Author: daohoangson

packages/core/lib/src/widgets/css_sizing.dart

@@ -209,19 +209,17 @@ class _RenderCssSizing extends RenderProxyBox {
         min(c.maxHeight, _maxHeight?.clamp(0.0, c.maxHeight) ?? c.maxHeight);
     final maxWidth =
         min(c.maxWidth, _maxWidth?.clamp(0.0, c.maxWidth) ?? c.maxWidth);
-    final minHeight =
+
+    final __minHeight =
         min(maxHeight, _minHeight?.clamp(0.0, c.maxHeight) ?? c.minHeight);
-    final minWidth =
+    final __minWidth =
         min(maxWidth, _minWidth?.clamp(0.0, c.maxWidth) ?? c.minWidth);
+    // ignore min value if it's infinite
+    final minHeight = __minHeight.isFinite ? __minHeight : .0;
+    final minWidth = __minWidth.isFinite ? __minWidth : .0;
 
-    final effectiveMinHeight =
-        c.hasTightHeight && _minHeight == null ? 0.0 : minHeight;
-    final effectiveMinWidth =
-        c.hasTightWidth && _minWidth == null ? 0.0 : minWidth;
-    final __preferredHeight =
-        _preferredHeight?.clamp(effectiveMinHeight, maxHeight);
-    final __preferredWidth =
-        _preferredWidth?.clamp(effectiveMinWidth, maxWidth);
+    final __preferredHeight = _preferredHeight?.clamp(minHeight, maxHeight);
+    final __preferredWidth = _preferredWidth?.clamp(minWidth, maxWidth);
     // ignore preferred value if it's infinite
     final preferredHeight =
         __preferredHeight?.isFinite == true ? __preferredHeight : null;

packages/core/test/style_sizing_test.dart

@@ -246,6 +246,27 @@ void main() {
         ),
       );
     });
+
+    testWidgets('renders 100%', (WidgetTester tester) async {
+      const html = '<div style="min-height: 100%">Foo</div>';
+      final explained = await explain(
+        tester,
+        null,
+        hw: SingleChildScrollView(
+          child: HtmlWidget(
+            html,
+            key: hwKey,
+          ),
+        ),
+      );
+      expect(
+        explained,
+        equals(
+          '[CssSizing:height≥100.0%,width=100.0%,child='
+          '[RichText:(:Foo)]]',
+        ),
+      );
+    });
   });
 
   group('min-width', () {
@@ -306,6 +327,28 @@ void main() {
         ),
       );
     });
+
+    testWidgets('renders 100%', (WidgetTester tester) async {
+      const html = '<div style="min-width: 100%">Foo</div>';
+      final explained = await explain(
+        tester,
+        null,
+        hw: SingleChildScrollView(
+          scrollDirection: Axis.horizontal,
+          child: HtmlWidget(
+            html,
+            key: hwKey,
+          ),
+        ),
+      );
+      expect(
+        explained,
+        equals(
+          '[CssSizing:width≥100.0%,width=100.0%,child='
+          '[RichText:(:Foo)]]',
+        ),
+      );
+    });
   });
 
   group('width', () {