Add support for list-style-type: none (#847)

Related to #811

Author: daohoangson

demo_app/pubspec.lock

@@ -42,7 +42,7 @@ packages:
       name: audio_session
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.1.10"
+    version: "0.1.13"
   boolean_selector:
     dependency: transitive
     description:
@@ -56,7 +56,7 @@ packages:
       name: cached_network_image
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "3.2.2"
+    version: "3.2.3"
   cached_network_image_platform_interface:
     dependency: transitive
     description:
@@ -77,7 +77,7 @@ packages:
       name: carousel_slider
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "4.1.1"
+    version: "4.2.1"
   characters:
     dependency: transitive
     description:
@@ -91,7 +91,7 @@ packages:
       name: chewie
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.3.5"
+    version: "1.3.6"
   clock:
     dependency: transitive
     description:
@@ -192,7 +192,7 @@ packages:
       name: flutter_svg
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.1.5"
+    version: "1.1.6"
   flutter_test:
     dependency: "direct dev"
     description: flutter
@@ -209,7 +209,7 @@ packages:
       path: "../packages/enhanced"
       relative: true
     source: path
-    version: "0.9.0+1"
+    version: "0.9.0+2"
   flutter_widget_from_html_core:
     dependency: "direct main"
     description:
@@ -277,7 +277,7 @@ packages:
       path: "../packages/fwfh_webview"
       relative: true
     source: path
-    version: "0.6.2+5"
+    version: "0.7.0"
   glob:
     dependency: transitive
     description:
@@ -366,7 +366,7 @@ packages:
       name: lint
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.10.0"
+    version: "2.0.1"
   logging:
     dependency: transitive
     description:
@@ -408,7 +408,7 @@ packages:
       name: mime
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.0.2"
+    version: "1.0.3"
   nested:
     dependency: transitive
     description:
@@ -471,7 +471,7 @@ packages:
       name: path_provider_android
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.0.20"
+    version: "2.0.22"
   path_provider_ios:
     dependency: transitive
     description:
@@ -562,21 +562,21 @@ packages:
       name: provider
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "6.0.4"
+    version: "6.0.5"
   pub_semver:
     dependency: transitive
     description:
       name: pub_semver
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.1.2"
+    version: "2.1.3"
   rxdart:
     dependency: transitive
     description:
       name: rxdart
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.27.5"
+    version: "0.27.7"
   shelf:
     dependency: transitive
     description:
@@ -604,7 +604,7 @@ packages:
       name: shelf_web_socket
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.0.2"
+    version: "1.0.3"
   sky_engine:
     dependency: transitive
     description: flutter
@@ -637,14 +637,14 @@ packages:
       name: sqflite
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.1.0+1"
+    version: "2.2.2"
   sqflite_common:
     dependency: transitive
     description:
       name: sqflite_common
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.3.0"
+    version: "2.4.0+2"
   stack_trace:
     dependency: transitive
     description:
@@ -721,14 +721,14 @@ packages:
       name: url_launcher
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "6.1.6"
+    version: "6.1.7"
   url_launcher_android:
     dependency: transitive
     description:
       name: url_launcher_android
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "6.0.19"
+    version: "6.0.22"
   url_launcher_ios:
     dependency: transitive
     description:
@@ -777,7 +777,7 @@ packages:
       name: uuid
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "3.0.6"
+    version: "3.0.7"
   vector_math:
     dependency: transitive
     description:
@@ -791,35 +791,35 @@ packages:
       name: video_player
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.4.7"
+    version: "2.4.10"
   video_player_android:
     dependency: transitive
     description:
       name: video_player_android
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.3.9"
+    version: "2.3.10"
   video_player_avfoundation:
     dependency: transitive
     description:
       name: video_player_avfoundation
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.3.7"
+    version: "2.3.8"
   video_player_platform_interface:
     dependency: transitive
     description:
       name: video_player_platform_interface
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "5.1.4"
+    version: "6.0.1"
   video_player_web:
     dependency: transitive
     description:
       name: video_player_web
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.0.12"
+    version: "2.0.13"
   vm_service:
     dependency: transitive
     description:
@@ -924,7 +924,7 @@ packages:
       name: win32
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "3.0.1"
+    version: "3.1.3"
   xdg_directories:
     dependency: transitive
     description:

packages/core/lib/src/core_widget_factory.dart

@@ -296,18 +296,26 @@ class WidgetFactory {
   ) {
     final text = getListMarkerText(listStyleType, index);
     final style = tsh.style;
-    return text.isNotEmpty
-        ? RichText(
-            maxLines: 1,
-            softWrap: false,
-            text: TextSpan(style: style, text: text),
-            textDirection: tsh.textDirection,
-          )
-        : listStyleType == kCssListStyleTypeCircle
-            ? HtmlListMarker.circle(style)
-            : listStyleType == kCssListStyleTypeSquare
-                ? HtmlListMarker.square(style)
-                : HtmlListMarker.disc(style);
+    if (text.isNotEmpty) {
+      return RichText(
+        maxLines: 1,
+        softWrap: false,
+        text: TextSpan(style: style, text: text),
+        textDirection: tsh.textDirection,
+      );
+    }
+
+    switch (listStyleType) {
+      case kCssListStyleTypeCircle:
+        return HtmlListMarker.circle(style);
+      case kCssListStyleTypeNone:
+        return null;
+      case kCssListStyleTypeSquare:
+        return HtmlListMarker.square(style);
+      case kCssListStyleTypeDisc:
+      default:
+        return HtmlListMarker.disc(style);
+    }
   }
 
   /// Builds [Padding].
@@ -490,9 +498,10 @@ class WidgetFactory {
       case kCssListStyleTypeRomanUpper:
         final roman = _getListMarkerRoman(i);
         return roman != null ? '$roman.' : '';
+      case kCssListStyleTypeNone:
+      default:
+        return '';
     }
-
-    return '';
   }
 
   String? _getListMarkerRoman(int i) {

packages/core/lib/src/internal/ops/tag_li.dart

@@ -19,6 +19,7 @@ const kCssListStyleTypeAlphaLatinUpper = 'upper-latin';
 const kCssListStyleTypeCircle = 'circle';
 const kCssListStyleTypeDecimal = 'decimal';
 const kCssListStyleTypeDisc = 'disc';
+const kCssListStyleTypeNone = 'none';
 const kCssListStyleTypeRomanLower = 'lower-roman';
 const kCssListStyleTypeRomanUpper = 'upper-roman';
 const kCssListStyleTypeSquare = 'square';

packages/core/test/tag_li_test.dart

@@ -315,6 +315,12 @@ Future<void> main() async {
         expect(explained, equals(padding(item(circle, 'Foo'))));
       });
 
+      testWidgets('renders none', (WidgetTester tester) async {
+        const html = '<ul style="list-style-type: none"><li>Foo</li></ul>';
+        final explained = await explain(tester, html);
+        expect(explained, equals(padding('[RichText:(:Foo)]')));
+      });
+
       testWidgets('renders square', (WidgetTester tester) async {
         const html = '<ul style="list-style-type: square"><li>Foo</li></ul>';
         final explained = await explain(tester, html);
@@ -325,6 +331,7 @@ Future<void> main() async {
         const html = '''
 <ul style="list-style-type: circle">
   <li style="list-style-type: disc"">disc</li>
+  <li style="list-style-type: none"">none</li>
   <li style="list-style-type: square">square</li>
   <li>circle</li>
 <ul>
@@ -336,6 +343,7 @@ Future<void> main() async {
             padding(
               list([
                 item(disc, 'disc'),
+                '[RichText:(:none)]',
                 item(square, 'square'),
                 item(circle, 'circle'),
               ]),